1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-23 07:12:41 +01:00
phorge-phorge/src
epriestley a10b91a6a9 Move connection cache from "AphrontDatabaseConnection"-level to "LiskDAO"-level
Summary:
  - Currently, connections are responsible for connection caching. However, I want unit tests to be able to say "throw away the entire connection cache" with storage fixtures, and this is difficult/impossible when connections are responsible for the cache.
  - The only behavioral change is that previously we would use the same connection for read-mode and write-mode queries. We'll now establish two connections. No installs actually differentiate between the modes so it isn't particularly relevant what we do here. In the long term, we should probably check the "w" cache before building a new "r" connection, so transactional code which involves reads and writes works (we don't have any such code right now).

Test Plan: Loaded pages, verified only one connection was established per database. Ran unit tests.

Reviewers: btrahan, vrana, jungejason, edward

Reviewed By: vrana

CC: aran

Maniphest Tasks: T140

Differential Revision: https://secure.phabricator.com/D2342
2012-04-30 11:57:10 -07:00
..
aphront Hard-code and unify "more applications" in Phabricator 2012-04-28 07:17:38 -07:00
applications Move connection cache from "AphrontDatabaseConnection"-level to "LiskDAO"-level 2012-04-30 11:57:10 -07:00
docs Make SQL patch management DAG-based and provide namespace support 2012-04-30 07:54:00 -07:00
infrastructure Make default database namespace configurable 2012-04-30 11:56:58 -07:00
storage Move connection cache from "AphrontDatabaseConnection"-level to "LiskDAO"-level 2012-04-30 11:57:10 -07:00
view Fix paging for 'before ID' queries 2012-04-27 17:27:00 -07:00
__celerity_resource_map__.php Inform about moved code and prefer it over copied code 2012-04-30 11:01:15 -07:00
__phutil_library_init__.php Distinguish between aphront and phabricator. 2011-01-22 17:45:28 -08:00
__phutil_library_map__.php Make SQL patch management DAG-based and provide namespace support 2012-04-30 07:54:00 -07:00