1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-30 18:52:42 +01:00
phorge-phorge/src/view/layout
Bob Trahan a161617d8e Conpherence - make the files widget purdy-ish
Summary:
does the title and also a few other small tweaks

- kills the init js behavior; now its part of menu where it belongs.
- adds the underline to the icon when its toggled in the widget menu
- fixed JS initialization errors on the "create conpherence" page. Note I still like keeping all that init stuff in one function because its typing the same data a bunch to be passed over to the JS layer. Other ways to accomplish this obvi...

Only fun wrinkle here is I think Chad intended me to display "when the file was attached". Instead, I display when the file was *uploaded*. I think this jives better with our version where you can't delete and all that. Files are pretty powerful, long-living objects in Phabricator land.

Test Plan: added files to a conpherence and noted widget loaded updated okay. added a file with no author (generated by the system) and verified it still rendered okay. switched between conpherences and verified proper data in each files widget. uploaded image and text files to check the icons were correct.

Reviewers: epriestley, chad

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T2530

Differential Revision: https://secure.phabricator.com/D5337
2013-03-15 23:41:36 -07:00
..
__tests__ Allow PhabricatorMenuView to have items inserted in the middle 2013-02-03 10:02:35 -08:00
AphrontContextBarView.php Restore merge of phutil_tag. 2013-02-13 14:51:18 -08:00
AphrontListFilterView.php Modernize Maniphest 2013-03-12 23:30:03 -07:00
AphrontMiniPanelView.php Restore merge of phutil_tag. 2013-02-13 14:51:18 -08:00
AphrontMoreView.php render_tag -> tag: fix more callsites (more view, misc) 2013-01-31 09:08:02 -08:00
AphrontPanelView.php Restore merge of phutil_tag. 2013-02-13 14:51:18 -08:00
AphrontSideNavFilterView.php Remove all calls to renderSingleView() and deprecate it 2013-03-09 13:52:41 -08:00
AphrontTwoColumnView.php Apront Two Column View 2013-03-10 19:20:01 -07:00
PhabricatorActionListView.php Remove all calls to renderSingleView() and deprecate it 2013-03-09 13:52:41 -08:00
PhabricatorActionView.php render_tag -> tag: phabricator_render_form -> phabricator_form 2013-01-30 11:30:38 -08:00
PhabricatorAnchorView.php Remove all calls to renderSingleView() and deprecate it 2013-03-09 13:52:41 -08:00
PhabricatorCrumbsView.php Remove all calls to renderSingleView() and deprecate it 2013-03-09 13:52:41 -08:00
PhabricatorCrumbView.php Fix AphrontCrumbView (phutil_tag) 2013-01-25 17:07:07 -08:00
PhabricatorFileLinkListView.php Restore merge of phutil_tag. 2013-02-13 14:51:18 -08:00
PhabricatorFileLinkView.php Conpherence - make the files widget purdy-ish 2013-03-15 23:41:36 -07:00
PhabricatorHeaderView.php Remove all calls to renderSingleView() and deprecate it 2013-03-09 13:52:41 -08:00
PhabricatorMenuItemView.php Remove all calls to renderSingleView() and deprecate it 2013-03-09 13:52:41 -08:00
PhabricatorMenuView.php Remove all calls to renderSingleView() and deprecate it 2013-03-09 13:52:41 -08:00
PhabricatorObjectItemListView.php Implement card style and extras for object item lists 2013-03-09 17:55:01 -08:00
PhabricatorObjectItemView.php Implement card style and extras for object item lists 2013-03-09 17:55:01 -08:00
PhabricatorPinboardItemView.php Remove all calls to renderSingleView() and deprecate it 2013-03-09 13:52:41 -08:00
PhabricatorPinboardView.php Remove all calls to renderSingleView() and deprecate it 2013-03-09 13:52:41 -08:00
PhabricatorProfileHeaderView.php Remove all calls to renderSingleView() and deprecate it 2013-03-09 13:52:41 -08:00
PhabricatorPropertyListView.php Group inline transactions in Pholio 2013-03-09 19:23:50 -08:00
PhabricatorSourceCodeView.php Line count can be set for paste 2013-03-14 10:51:34 -07:00
PhabricatorTagView.php pht() for view and form elements 2013-03-01 15:37:33 -08:00
PhabricatorTimelineEventView.php Fix two Pholio subscriptions issues 2013-03-10 10:59:03 -07:00
PhabricatorTimelineView.php Remove all calls to renderSingleView() and deprecate it 2013-03-09 13:52:41 -08:00
PhabricatorTransactionView.php Remove all calls to renderSingleView() and deprecate it 2013-03-09 13:52:41 -08:00