mirror of
https://we.phorge.it/source/phorge.git
synced 2025-02-16 00:38:38 +01:00
65f13b156f
Summary: See PHI158. In the RefEngine, we test if any old branch positions have been removed from the repository. This is uncommon (but not impossible) in Mercurial, and corresponds to users deleting branches in Git. Currently, we end up running `hg log` for each position, in parallel. Because of Python's large startup overhead, this can be resource intensive for repositories with a large number of branches. We have to do this in the general case because the caller may be asking us to resolve `tip`, `newfeature`, `tip~3`, `9`, etc. However, in the specific case where the refs are 40-digit hashes, we can bulk resolve them if they exist, like this: ``` hg log ... --rev (abcd or def0 or ab12 or ...) ``` In the general case, we could probably do less of this than we currently do (instead of testing all old heads, we could prune the list by removing commits which we know are still pointed to by current heads) but that's a slightly more involved change and the effect here is already dramatic. Test Plan: Verified that CPU usage drops from ~110s -> ~0.9s: Before: ``` epriestley@orbital ~/dev/phabricator $ time ./bin/repository refs nss Updating refs in "nss"... Done. real 0m14.676s user 1m24.714s sys 0m21.645s ``` After: ``` epriestley@orbital ~/dev/phabricator $ time ./bin/repository refs nss Updating refs in "nss"... Done. real 0m0.861s user 0m0.882s sys 0m0.213s ``` - Manually resolved `blue`, `tip`, `9`, etc., got expected results. - Tried to resolve invalid hashes, got expected result (no resolution). Reviewers: amckinley Reviewed By: amckinley Differential Revision: https://secure.phabricator.com/D18717 |
||
|---|---|---|
| .. | ||
| DiffusionLowLevelCommitFieldsQuery.php | ||
| DiffusionLowLevelCommitQuery.php | ||
| DiffusionLowLevelGitRefQuery.php | ||
| DiffusionLowLevelMercurialBranchesQuery.php | ||
| DiffusionLowLevelMercurialPathsQuery.php | ||
| DiffusionLowLevelParentsQuery.php | ||
| DiffusionLowLevelQuery.php | ||
| DiffusionLowLevelResolveRefsQuery.php | ||