1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-25 15:00:58 +01:00
phorge-phorge/src/applications/herald
epriestley cd3a3bf759 Make Herald Rules sticky in X-Herald-Rules
Summary:
See T354. List every rule which has ever been applied in X-Herald-Rules, not
just the ones which most recently triggered.

Also some random fixes while I was debugging this:

  - When conduit methods throw non-conduit exceptions, make sure they get
logged.
  - Trigger the Facebook "tasks" backcompat block only if we were going to fail
(this should reduce the shakniess of the transition).
  - Fix some log spew from the new field stuff.

Test Plan:
  - Created a rule (ID #3) "No Zebras" which triggers for revisions without
"zebra" in the title.
  - Created a revision without "zebra" in the title, got X-Herald-Rules: <2>,
<3>
  - Updated revision to have "zebra" in the title, verified rule did not trigger
in Herald transcript.
  - Verified X-Herald-Rules is still: <2>, <3>

Reviewed By: aran
Reviewers: aran, jungejason, tuomaspelkonen
CC: aran, epriestley
Differential Revision: 817
2011-08-17 10:38:29 -07:00
..
adapter herald: add the ability to execute a rule the first time only 2011-06-09 10:35:37 -07:00
config herald: add the ability to execute a rule the first time only 2011-06-09 10:35:37 -07:00
controller Fix Herald to accept new JSON encoding of sparse arrays 2011-07-07 15:27:12 -07:00
engine Fix Herald exception when updating a diff that has carryover CCs 2011-06-09 14:10:40 -07:00
storage Make Herald Rules sticky in X-Herald-Rules 2011-08-17 10:38:29 -07:00