1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-24 14:30:56 +01:00
phorge-phorge/webroot/rsrc/js/application
epriestley c544f78015 When a user hits "Reply", then "Cancel" on an inline comment (without typing),
don't show "Undo"

Summary: When a user hits "Reply" on an inline comment, doesn't type anything,
and then hits "Cancel", we incorrectly store the text of the comment the user is
replying to as the "original" text, and then detect that they've changed it when
they immediately cancel. Instead, store empty string as the original text.

Test Plan:
  - Hit "Reply" and then "Cancel" on an inline comment. No undo now.
  - Hit "Reply", typed some text, and then hit "Cancel". Got an undo which
restored my text.

Reviewers: tomo, jungejason, tuomaspelkonen, aran

Reviewed By: aran

CC: aran, tomo

Differential Revision: 879
2011-08-31 12:04:17 -07:00
..
core Prevent CSRF uploads via /file/dropupload/ 2011-08-16 13:19:10 -07:00
countdown Remove usage of JX.defer in favor of setTimeout 2011-08-10 18:09:59 -07:00
differential When a user hits "Reply", then "Cancel" on an inline comment (without typing), 2011-08-31 12:04:17 -07:00
diffusion Remove usage of JX.defer in favor of setTimeout 2011-08-10 18:09:59 -07:00
herald Remove usage of JX.defer in favor of setTimeout 2011-08-10 18:09:59 -07:00
maniphest Defer initial preview until CSRF header for JX.Request loads. 2011-08-16 14:31:52 -07:00
owners Bring Javelin into Phabricator via git submodule, not copy-and-paste 2011-05-08 13:20:10 -07:00
phriction Add a document preview to Phriction 2011-07-16 18:48:27 -07:00
projects Allow administrative editing of project resources 2011-07-21 16:46:28 -07:00