1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-09-21 17:58:47 +02:00
phorge-phorge/src/applications/repository
epriestley 0a069cb55a Require a viewer to load handles
Summary:
Unmuck almost all of the we-sort-of-have-viewers-some-of-the-time mess.

There are a few notable cases here:

  - I used Omnipotent users when indexing objects for search. I think this is correct; we do policy filtering when showing results.
  - I cheated in a bad way in the Remarkup object rule, but fixing this requires fixing all the PhabricatorRemarkupEngine callsites (there are 85). I'll do that in the next diff.
  - I cheated in a few random places, like when sending mail about package edits. These aren't a big deal.

Test Plan:
  - Grepped for all PhabricatorObjectHandleData references.
  - Gave them viewers.

Reviewers: vrana

Reviewed By: vrana

CC: aran, edward

Maniphest Tasks: T603

Differential Revision: https://secure.phabricator.com/D5151
2013-02-28 17:15:09 -08:00
..
application Use application icons for "Eye" menu and Crumbs 2012-12-07 13:37:28 -08:00
conduit Prevent exceptions when adding repositories via conduit. 2013-01-10 15:37:56 -08:00
constants Delete license headers from files 2012-11-05 11:16:51 -08:00
controller Restore merge of phutil_tag. 2013-02-13 14:51:18 -08:00
daemon Allow phabricator to manage repositories 2012-12-12 14:43:09 -08:00
management Delete license headers from files 2012-11-05 11:16:51 -08:00
query Order repositories in Diffusion from oldest 2012-12-20 15:49:37 -08:00
search Apply lint rules to Phabricator 2013-02-19 13:33:10 -08:00
storage Prepare Diffusion for hovercards 2013-02-27 08:04:54 -08:00
worker Require a viewer to load handles 2013-02-28 17:15:09 -08:00
PhabricatorRepositoryConfigOptions.php Repository option. 2013-01-16 09:35:48 -08:00