revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-13 10:22:42 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications/harbormaster/step
History
epriestley a246c85c6b Use ApplicationTransactions and CustomField to implement build steps 
Summary:
Ref T1049. Fixes T4602. Moves all the funky field stuff to CustomField. Uses ApplicationTransactions to apply and record edits.

This makes "artifact" fields a little less nice (but still perfectly usable). With D8599, I think they're reasonable overall. We can improve this in the future.

All other field types are better (e.g., fixes weird bugs with "bool", fixes lots of weird behavior around required fields), and this gives us access to many new field types.

Test Plan:
Made a bunch of step edits. Here's an example:

{F133694}

Note that:

  - "Required" fields work correctly.
  - the transaction record is shown at the bottom of the page.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T4602, T1049

Differential Revision: https://secure.phabricator.com/D8600
2014-03-25 16:08:40 -07:00
..
BuildStepImplementation.php Use ApplicationTransactions and CustomField to implement build steps 2014-03-25 16:08:40 -07:00
CommandBuildStepImplementation.php Use ApplicationTransactions and CustomField to implement build steps 2014-03-25 16:08:40 -07:00
HarbormasterHTTPRequestBuildStepImplementation.php Use ApplicationTransactions and CustomField to implement build steps 2014-03-25 16:08:40 -07:00
HarbormasterThrowExceptionBuildStep.php Improve several exception behaviors for Harbormaster workers 2014-01-13 12:21:49 -08:00
LeaseHostBuildStepImplementation.php Use ApplicationTransactions and CustomField to implement build steps 2014-03-25 16:08:40 -07:00
PublishFragmentBuildStepImplementation.php Use ApplicationTransactions and CustomField to implement build steps 2014-03-25 16:08:40 -07:00
SleepBuildStepImplementation.php Use ApplicationTransactions and CustomField to implement build steps 2014-03-25 16:08:40 -07:00
UploadArtifactBuildStepImplementation.php Use ApplicationTransactions and CustomField to implement build steps 2014-03-25 16:08:40 -07:00
WaitForPreviousBuildStepImplementation.php Improve several exception behaviors for Harbormaster workers 2014-01-13 12:21:49 -08:00