1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-23 23:32:40 +01:00
phorge-phorge/src/applications/audit
epriestley c125ab7a42 Remove "metamta.*.subject-prefix" options
Summary:
In ~2012, the first of these options was added because someone who hates dogs and works at Asana also hated `[Differential]` in the subject line. The use case there was actually //removing// the text, not changing it, but I made the prefix editable since it seemed like slightly less of a one-off.

These options are among the dumbest and most useless config options we have and very rarely used, see T11760. A very small number of instances have configured one of these options.

Newer applications stopped providing these options and no one has complained.

You can get the same effect with `translation.override`. Although I'm not sure we'll keep that around forever, it's a reasonable replacement today. I'll call out an example in the changelog to help installs that want to preserve this option.

If we did want to provide this, it should just be in {nav Applications > Settings} for each application, but I think it's wildly-low-value and "hack via translations" or "local patch" are entirely reasonable if you really want to change these strings.

Test Plan: Grepped for `subject-prefix`.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D19993
2019-01-17 19:18:50 -08:00
..
application Provide bucketing for commits in Audit 2017-01-12 12:04:05 -08:00
conduit Rename "PhabricatorAuditCommitStatusConstants" to "DiffusionCommitAuditStatus"; remove "MODERN_" 2018-09-12 12:44:43 -07:00
constants Rename "PhabricatorAuditCommitStatusConstants" to "DiffusionCommitAuditStatus"; remove "MODERN_" 2018-09-12 12:44:43 -07:00
controller Merge "Audit" more completely into "Diffusion" 2017-01-11 16:28:42 -08:00
editor Remove "metamta.*.subject-prefix" options 2019-01-17 19:18:50 -08:00
mail Allow multiple mail receivers to react to an individual email 2019-01-16 12:28:02 -08:00
management Introduce an AuditStatus object for commits and move some callsites to it 2018-09-07 10:20:04 -07:00
query Expose "identifiers" as a query constraint for Commit search 2018-11-24 07:20:01 -08:00
storage Remove "willRenderTimeline()" from ApplicationTransactionInterface 2018-12-20 14:55:07 -08:00
view Introduce an AuditStatus object for commits and move some callsites to it 2018-09-07 10:20:04 -07:00