1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-23 23:32:40 +01:00
phorge-phorge/src/applications/herald
epriestley 15df57f1c8 In Webhooks, give errors human-readable labels and show reminder text for "Silent Mode"
Summary:
Depends on D19928. See <https://discourse.phabricator-community.org/t/firehose-webhook-not-working-with-self-hosted-requestbin-instance/2240/>.

Currently, we report "hook" and "silent", which are raw internal codes.

Instead, report human-readable labels so the user gets a better hint about what's going on ("In Silent Mode").

Also, render a "hey, you're in silent mode so none of this will work" reminder banner in this UI.

Test Plan:
{F6074421}

Note:

  - New warning banner.
  - Table has more human-readable text ("In Silent Mode").

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D19929
2018-12-28 00:05:46 -08:00
..
action Prevent "Call webhooks" Herald action from appearing in UI for adapters which can't fire it 2018-02-11 06:15:29 -08:00
adapter Support Herald rules for Herald rules 2018-04-25 06:47:19 -07:00
application Document how webhooks work 2018-02-09 13:57:19 -08:00
capability Add skeleton code for webhooks 2018-02-09 13:55:04 -08:00
config Remove "HeraldRepetitionPolicyConfig" and hide storage details inside HeraldRule 2018-01-26 11:03:29 -08:00
contentsource Modularize content sources 2016-03-26 11:59:45 -07:00
controller In Webhooks, give errors human-readable labels and show reminder text for "Silent Mode" 2018-12-28 00:05:46 -08:00
editor Add a "Rule Detail" link to Herald email 2018-04-30 05:20:12 -07:00
engine Fix a stray qsprintf() in the Herald rules engine when recording rule application to objects 2018-12-12 11:31:36 -08:00
engineextension Fully modularize DestructionEngine 2015-12-21 17:03:44 -08:00
field Add "Content type" and "Rule type" fields to Herald rules for Herald rules 2018-04-25 06:54:48 -07:00
garbagecollector Refine core webhook implementation somewhat 2018-02-09 13:55:55 -08:00
group Make Herald action modularization more aggressive 2015-08-03 14:33:20 -07:00
mail Support Herald rules for Herald rules 2018-04-25 06:47:19 -07:00
management Add a bin/herald test ... for doing test runs via the CLI 2018-11-15 15:48:52 -08:00
phid Trigger all "Firehose" webhooks on all transactional edits 2018-02-09 13:56:34 -08:00
query Add a bin/herald test ... for doing test runs via the CLI 2018-11-15 15:48:52 -08:00
remarkup Rename PhutilRemarkupRule subclasses 2014-08-05 00:55:43 +10:00
state Prepare TransactionEditor for silent transactions via bulk edit 2018-01-19 13:23:38 -08:00
storage In Webhooks, give errors human-readable labels and show reminder text for "Silent Mode" 2018-12-28 00:05:46 -08:00
typeahead Support querying Herald rules by monogram in typeahead datsources 2018-08-01 17:52:27 -07:00
value Respect token limits for "Assign to" and custom datasource fields in Herald 2018-01-22 11:54:12 -08:00
view In Webhooks, give errors human-readable labels and show reminder text for "Silent Mode" 2018-12-28 00:05:46 -08:00
worker In Webhooks, give errors human-readable labels and show reminder text for "Silent Mode" 2018-12-28 00:05:46 -08:00
xaction Refine core webhook implementation somewhat 2018-02-09 13:55:55 -08:00