1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-24 07:42:40 +01:00
phorge-phorge/src/applications/owners/storage
epriestley 4a98e0ff65 Allow Owners packages to be configured to ignore generated paths in Differential
Summary:
Depends on D19427. Ref T13130. See PHI251. Support configuring owners packages so they ignore generated paths.

This is still a little rough. A couple limitations:

  - It's hard to figure out how to use this control if you don't know what it's for, but we don't currently have a "CheckboxesEditField". I may add that soon.
  - The attribute ignore list doesn't apply to Diffusion, only Differential, which isn't obvious. I'll either try to make it work in Diffusion or note this somewhere.
  - No documentation yet (which could mitigate the other two issues a bit).

But the actual behavior seems to work fine.

Test Plan:
  - Set a package to ignore paths with the "generated" attribute. Saw the package stop matching generated paths in Differential.
  - Removed the attribute from the ignore list.
  - Tried to set invalid attributes, got sensible errors.
  - Queried a package with Conduit, got the ignored attribute list.

Reviewers: amckinley

Reviewed By: amckinley

Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam

Maniphest Tasks: T13130

Differential Revision: https://secure.phabricator.com/D19428
2018-05-05 08:47:29 -07:00
..
__tests__ Fix spelling 2017-10-09 10:48:04 -07:00
PhabricatorOwnersCustomFieldNumericIndex.php Add CustomField support to Owners 2015-09-10 13:32:31 -07:00
PhabricatorOwnersCustomFieldStorage.php Add CustomField support to Owners 2015-09-10 13:32:31 -07:00
PhabricatorOwnersCustomFieldStringIndex.php Add CustomField support to Owners 2015-09-10 13:32:31 -07:00
PhabricatorOwnersDAO.php Delete license headers from files 2012-11-05 11:16:51 -08:00
PhabricatorOwnersOwner.php Fix expansion of projects into lists of user PHIDs 2016-05-24 06:38:37 -07:00
PhabricatorOwnersPackage.php Allow Owners packages to be configured to ignore generated paths in Differential 2018-05-05 08:47:29 -07:00
PhabricatorOwnersPackageNameNgrams.php Implement basic ngram search for Owners Package names 2015-12-22 08:00:33 -08:00
PhabricatorOwnersPackageTransaction.php Fix an issue with attempting to index comments on packages 2017-10-20 09:38:45 -07:00
PhabricatorOwnersPath.php Use "pathIndex" in some owners package queries to improve query plans 2018-03-06 20:33:18 -08:00
PhabricatorOwnersSchemaSpec.php Fix file PHID extraction in Owners and Differential 2015-11-17 08:36:50 -08:00