1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-24 13:38:19 +01:00
phorge-phorge/src/applications/differential/storage
epriestley b2d280ff51 Port comments through time and space in the common/best case
Summary:
Ref T7447. This ports comments forward and backward in the best case:

  - The old comment is on a changeset with the same filename.
  - The old and new files are pretty much the same, line-for-line.

This will fail to port a lot of comments around and probably port a lot of comments into goofy places. We can see how bad it is in practice.

Errata:

  - Design is me cobbling something together, probably worth tweaking.
  - "Old Comment" should, at a minimum, say "Newer Comment" sometimes, or we should come up with some better name for this stuff.

Test Plan: {F377214}

Reviewers: chad, btrahan

Reviewed By: btrahan

Subscribers: johnny-bit, yelirekim, epriestley

Maniphest Tasks: T7447

Differential Revision: https://secure.phabricator.com/D12484
2015-04-21 11:06:44 -07:00
..
__tests__ Detect moves and copies with some unchanged lines as moves or copies 2015-03-24 13:12:24 -07:00
DifferentialAffectedPath.php Fix visiblity of LiskDAO::getConfiguration() 2015-01-14 06:54:13 +11:00
DifferentialChangeset.php Rename DifferentialHunk subclasses for consistency 2015-01-23 07:17:04 +11:00
DifferentialCustomFieldNumericIndex.php Various linter fixes. 2014-02-26 12:44:58 -08:00
DifferentialCustomFieldStorage.php Various linter fixes. 2014-02-26 12:44:58 -08:00
DifferentialCustomFieldStringIndex.php Various linter fixes. 2014-02-26 12:44:58 -08:00
DifferentialDAO.php Delete license headers from files 2012-11-05 11:16:51 -08:00
DifferentialDiff.php Rename DifferentialHunk subclasses for consistency 2015-01-23 07:17:04 +11:00
DifferentialDiffProperty.php Fix almost all remaining schemata issues 2014-10-01 08:18:36 -07:00
DifferentialDiffTransaction.php Differential - make DifferentialDiffEditor into a real transaction editor. 2014-11-18 15:32:23 -08:00
DifferentialDraft.php Fix visiblity of LiskDAO::getConfiguration() 2015-01-14 06:54:13 +11:00
DifferentialHunk.php Provide better parsing primitives for hunks 2015-03-24 13:11:37 -07:00
DifferentialInlineComment.php Port comments through time and space in the common/best case 2015-04-21 11:06:44 -07:00
DifferentialLegacyHunk.php Rename DifferentialHunk subclasses for consistency 2015-01-23 07:17:04 +11:00
DifferentialModernHunk.php Rename DifferentialHunk subclasses for consistency 2015-01-23 07:17:04 +11:00
DifferentialReviewer.php Rename PHIDType classes 2014-07-24 08:05:46 +10:00
DifferentialRevision.php Modernize DifferentialInlineCommentQuery 2015-04-21 11:06:44 -07:00
DifferentialSchemaSpec.php Automatically build all Lisk schemata 2014-10-02 09:51:20 -07:00
DifferentialTransaction.php Lift inline comment state transactions into core (in Differential) 2015-03-24 05:26:16 -07:00
DifferentialTransactionComment.php Write "hasReplies" to database for inline comments 2015-03-09 14:11:16 -07:00