1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-03-19 07:40:09 +01:00
phorge-phorge/src/view
epriestley b62420e6e4 Separate reading object values out of didSetObject() in CustomField
Summary:
Ref T3886. Broadly, fields break down into two types right now: fields which store data on the object (like `DifferentialTitleField`) and fields which store data in custom field storage.

The former type generally reads data from the object into local storage prior to editing, then writes it back afterward. Currently, this happens in `didSetObject()`.

However, now that we load and set objects from ApplicationTransactionQuery, we'll do this extra read-field-values on view interfaces too. There, it's unnecessary and sometimes throws data-attached exceptions.

Instead, separate these concepts, and do all the read-from-object / read-from-storage in one logical chunk, separate from `didSetObject()`.

Test Plan:
  - Edited Differential revision.
  - Edited Maniphest task.
  - Edited Project.
  - Edited user profile.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T3886

Differential Revision: https://secure.phabricator.com/D8299
2014-02-21 14:44:01 -08:00
..
__tests__ Provide hasChildren() to replace isEmptyContent() 2013-08-12 07:51:01 -07:00
control Provide result type information in tokenizers 2014-02-14 10:23:56 -08:00
form Separate reading object values out of didSetObject() in CustomField 2014-02-21 14:44:01 -08:00
layout PHUITimelineView 2014-02-12 09:02:05 -08:00
page Replace "search scope" with selectable default behavior 2014-02-03 14:29:49 -08:00
phui Move "Open in Editor" to File Box 2014-02-21 14:43:24 -08:00
widget Move PhabricatorTagView to PHUITagView 2014-01-14 14:09:52 -08:00
AphrontDialogView.php Improve handling of email verification and "activated" accounts 2013-11-12 14:37:04 -08:00
AphrontJavelinView.php Partial fix for Javelin View Example 2013-07-16 13:31:43 -07:00
AphrontNullView.php Provide hasChildren() to replace isEmptyContent() 2013-08-12 07:51:01 -07:00
AphrontTagView.php Remove all the container node stuff from AphrontTagView 2013-06-05 16:21:55 -07:00
AphrontView.php Allow CelerityResourceResponse to hold resources from multiple maps 2014-01-02 11:59:35 -08:00
viewutils.php User preference for time format 2013-09-02 12:55:11 -07:00