1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-15 11:22:40 +01:00
phorge-phorge/src/applications/herald
Neal Poole 1edb875978 Adding support for 'adds' and 'removes' in diff content.
Summary:
Does what it says on the label. We already had 'Any changed file content', now we have 'Any added file content' and 'Any removed file content'.
- There is a bit of copied/pasted code here: I'm open to suggestions on how to refactor it so it's less redundant.
- The wording seems a little awkward, and as @epriestley mentioned in T3829, moved code will be detected less than ideally.

Test Plan: Created Herald Rules, verified via dry run that they were triggered in appropriate situations.

Reviewers: epriestley

Reviewed By: epriestley

CC: Korvin, aran

Maniphest Tasks: T3829

Differential Revision: https://secure.phabricator.com/D7214
2013-10-04 06:37:39 -07:00
..
adapter Adding support for 'adds' and 'removes' in diff content. 2013-10-04 06:37:39 -07:00
application Add a normal "view" page for Herald rules 2013-08-07 18:04:39 -07:00
config Remove HeraldActionConfig, HeraldFieldConfig 2013-08-07 18:04:37 -07:00
controller Provide more structure to PHUIObjectBoxView 2013-09-30 09:36:04 -07:00
engine Herald - make dry runs work for "apply once" rules after they have been applied 2013-09-13 11:38:49 -07:00
phid Policy - introduce parentQuery and pass around policy configuration from parent to child 2013-09-11 12:19:34 -07:00
query Kill PhabricatorObjectDataHandle 2013-09-11 12:27:28 -07:00
storage Adding support for 'adds' and 'removes' in diff content. 2013-10-04 06:37:39 -07:00
view Move PhabricatorObjectItem to PHUIObjectItem, add 'plain' setting for lists. 2013-09-09 14:14:34 -07:00