mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-15 03:12:41 +01:00
221562b294
Summary:
Modernizes file uploads. In particular:
- Adds a mobile menu, with an "Upload File" item.
- Adds crumbs to the list view, detail view and upload view.
- Adds "Upload File" action to crumbs.
- Moves upload file to a separate page.
- Removes the combined upload file + recent files page.
- Makes upload file use a normal file control by default (works on mobile).
- Home page, file list and file upload page are now global drop targets which accept files dropped anywhere on them. Dragging a file into the window shows a mask and an instructional message.
- User education on this is a little weak but I think that's a big can of worms?
- Fixes a bug where dropping multiple files into a Remarkup text area produced bad results (resolves T2190).
T879 is related, although it's specifically about Maniphest. I've declined to make global drop targets yet there because there are multiple drop targets on the page with different meanings. That UI needs updating in general.
@chad, do we have an "upload" icon (counterpart to "download")?
Test Plan: Uploaded files in Maniphest, Differential, Files, and from Home. Dragged and dropped multiple files into Differential. Used crumbs, mobile.
Reviewers: chad, btrahan
Reviewed By: btrahan
CC: aran
Maniphest Tasks: T2190
Differential Revision: https://secure.phabricator.com/D4200
44 lines
1.1 KiB
PHP
44 lines
1.1 KiB
PHP
<?php
|
|
|
|
abstract class PhabricatorFileController extends PhabricatorController {
|
|
|
|
public function buildApplicationCrumbs() {
|
|
$crumbs = parent::buildApplicationCrumbs();
|
|
$crumbs->addAction(
|
|
id(new PhabricatorMenuItemView())
|
|
->setName(pht('Upload File'))
|
|
->setIcon('create') // TODO: Get @chad to build an "upload" icon.
|
|
->setHref($this->getApplicationURI('/upload/')));
|
|
|
|
return $crumbs;
|
|
}
|
|
|
|
protected function buildSideNavView() {
|
|
$menu = $this->buildMenu($for_devices = false);
|
|
return AphrontSideNavFilterView::newFromMenu($menu);
|
|
}
|
|
|
|
protected function buildApplicationMenu() {
|
|
return $this->buildMenu($for_devices = true);
|
|
}
|
|
|
|
private function buildMenu($for_devices) {
|
|
$menu = new PhabricatorMenuView();
|
|
|
|
if ($for_devices) {
|
|
$menu->newLink(pht('Upload File'), $this->getApplicationURI('/upload/'));
|
|
}
|
|
|
|
$menu->newLabel(pht('Filters'));
|
|
|
|
$menu->newLink(pht('My Files'), $this->getApplicationURI('filter/my/'))
|
|
->setKey('my');
|
|
|
|
$menu->newLink(pht('All Files'), $this->getApplicationURI('filter/all/'))
|
|
->setKey('all');
|
|
|
|
return $menu;
|
|
}
|
|
|
|
|
|
}
|