mirror of
https://we.phorge.it/source/phorge.git
synced 2024-09-22 10:18:48 +02:00
3d3d3b6d80
Summary: Ref T1279. We currently determine reviewers at display time, but this is bad for several reasons: - It puts queries very close to the display layer. - We have to query for each revision if we want to figure out authority for several. - We need to figure it out in several places, so we'll end up with copies of this logic. - The logic isn't trivial (exceptions for the viewer, exceptions to that rule for install configuration). - We already do this "figure it out when we need it" stuff in Diffusion for audits and it's really bad: we have half-working copies of the logic spread all over the place. Instead, put it in the Query. Callers query for it and get the data attached to the reviewer objects. Test Plan: - Looked at some revisions, verified the correct lines were highlighted. - Looked at a revision I created and verified that projects I was a member of were not highlighted. - With self-accept enabled, these //are// highlighted. - Looked at a revision I did not create and verified that projects I was a member of were highlighted. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T1279 Differential Revision: https://secure.phabricator.com/D7241
49 lines
1.2 KiB
PHP
49 lines
1.2 KiB
PHP
<?php
|
|
|
|
final class DifferentialReviewer {
|
|
|
|
private $reviewerPHID;
|
|
private $status;
|
|
private $diffID;
|
|
private $authority = array();
|
|
|
|
public function __construct($reviewer_phid, array $edge_data) {
|
|
$this->reviewerPHID = $reviewer_phid;
|
|
$this->status = idx($edge_data, 'status');
|
|
$this->diffID = idx($edge_data, 'diff');
|
|
}
|
|
|
|
public function getReviewerPHID() {
|
|
return $this->reviewerPHID;
|
|
}
|
|
|
|
public function getStatus() {
|
|
return $this->status;
|
|
}
|
|
|
|
public function getDiffID() {
|
|
return $this->diffID;
|
|
}
|
|
|
|
public function isUser() {
|
|
$user_type = PhabricatorPeoplePHIDTypeUser::TYPECONST;
|
|
return (phid_get_type($this->getReviewerPHID()) == $user_type);
|
|
}
|
|
|
|
public function attachAuthority(PhabricatorUser $user, $has_authority) {
|
|
$this->authority[$user->getPHID()] = $has_authority;
|
|
return $this;
|
|
}
|
|
|
|
public function hasAuthority(PhabricatorUser $viewer) {
|
|
// It would be nice to use assertAttachedKey() here, but we don't extend
|
|
// PhabricatorLiskDAO, and faking that seems sketchy.
|
|
|
|
$viewer_phid = $viewer->getPHID();
|
|
if (!array_key_exists($viewer_phid, $this->authority)) {
|
|
throw new Exception("You must attachAuthority() first!");
|
|
}
|
|
return $this->authority[$viewer_phid];
|
|
}
|
|
|
|
}
|