1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-02-28 14:39:36 +01:00
phorge-phorge/src/applications/conpherence/view
Austin McKinley 3e05ff2e99 Improve Conpherence behavior for logged out users.
Summary:
There are two issues here I was trying to fix:

* Viewing `/conpherence` by logged out users on `secure` would generate an overheated query on `ConpherenceThreadQuery` `secure` has a ton of wacky threads with bogus names.
* When a user views a specific thread that they don't have permission to see, we attempt to fetch the thread's transactions before applying policy filtering. If the thread has more than 1000 comments, that query will also overheat instead of returning a policy exception.

I fixed the first problem, but started trying to fix the second by moving the transaction fetch to `didFilterPage` but it broke in strange ways so I gave up.

Also fix a dangling `qsprintf` update.

Test Plan: Loaded threads and the Conpherence homepage with and without logged in users.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D20375
2019-04-02 14:03:08 -07:00
..
ConpherenceDurableColumnView.php Separate button CSS classes 2017-06-05 20:14:34 +00:00
ConpherenceLayoutView.php Improve Conpherence behavior for logged out users. 2019-04-02 14:03:08 -07:00
ConpherenceMenuItemView.php Clean up random junk in Conpherence 2016-09-09 07:16:39 -07:00
ConpherenceParticipantView.php Rebuild Conpherence Participants Pane 2016-09-15 13:21:31 -07:00
ConpherenceThreadListView.php Update Conpherence to use EditEngine 2017-04-29 19:39:12 -07:00
ConpherenceTransactionView.php Convert date-marker to ModularTransaction in Conpherence 2017-04-13 13:01:36 -07:00