revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-02-28 14:39:36 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications/transactions/editengine
History
Andre Klapper 6e88528370 Fix PHP 8.1 "strlen(null)" exception which blocks rendering list of Active/All projects 
Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15312

Test Plan:
Applied this change (on top of D25144, D25145, D25146, D25147, D25151, D25152, D25153 and `/project/query/active/` rendered correctly in web browser.

Tested surfing various pages with and without Maniphest's `maniphest.subtypes`.

If you need some example custom fields, this is an example:

```
[
    {
      "key": "default",
      "name": "Task"
    },
    {
      "key": "bug",
      "name": "Bug"
    },
    {
      "key": "log",
      "name": "LogSpam"
    },
    {
      "key": "deadline",
      "name": "Deadline"
    }
  ]
```

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15312

Differential Revision: https://we.phorge.it/D25162
2023-05-01 15:55:42 +02:00
..
__tests__ Add a "subtype" field to EditEngine forms 2017-03-02 04:16:27 -08:00
PhabricatorEditEngine.php Fix PHP 8.1 "strlen(null)" exceptions which block rendering the Maniphest task creation page 2023-05-01 15:52:23 +02:00
PhabricatorEditEngineAPIMethod.php Add a side nav to Conduit API method console pages 2021-07-21 14:16:59 -07:00
PhabricatorEditEngineDefaultLock.php Allow task statuses to "lock" them, preventing additional comments and interactions 2017-03-02 16:57:10 -08:00
PhabricatorEditEngineLock.php Allow task statuses to "lock" them, preventing additional comments and interactions 2017-03-02 16:57:10 -08:00
PhabricatorEditEngineLockableInterface.php Allow task statuses to "lock" them, preventing additional comments and interactions 2017-03-02 16:57:10 -08:00
PhabricatorEditEngineMFAEngine.php Always require MFA to edit contact numbers 2019-01-23 14:19:56 -08:00
PhabricatorEditEngineMFAInterface.php Allow objects to be put in an "MFA required for all interactions" mode, and support "MFA required" statuses in Maniphest 2018-12-28 00:10:54 -08:00
PhabricatorEditEnginePageState.php Replace old hard-coded URI-based "changes saved" jank with new overgeneralized cookie-based "changes saved" jank 2020-04-19 09:04:31 -07:00
PhabricatorEditEngineSubtype.php Fix PHP 8.1 "strlen(null)" exception which blocks rendering list of Active/All projects 2023-05-01 15:55:42 +02:00
PhabricatorEditEngineSubtypeInterface.php Allow EditEngine forms for objects which support subtyping to have a subtype configured 2017-03-02 04:18:06 -08:00
PhabricatorEditEngineSubtypeMap.php Allow subtypes to specify "mutations", to control the behavior of the "Change Subtype" action 2019-09-12 16:17:02 -07:00
PhabricatorEditPage.php Split Repository EditEngine form into smaller pages 2016-05-02 08:28:38 -07:00