1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-24 07:42:40 +01:00
phorge-phorge/src/aphront
epriestley 66366137ff Don't apply security.require-https to intracluster requests
Summary:
Ref T10784. Currently, if you terminate SSL at a load balancer (very common) and use HTTP beyond that, you have to fiddle with this setting in your premable or a `SiteConfig`.

On the balance I think this makes stuff much harder to configure without any real security benefit, so don't apply this option to intracluster requests.

Also document a lot of stuff.

Test Plan: Poked around locally but this is hard to test outside of a production cluster, I'll vet it more thoroughly on `secure`.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10784

Differential Revision: https://secure.phabricator.com/D15696
2016-04-13 12:51:41 -07:00
..
__tests__ phtize all the things 2015-05-22 21:16:39 +10:00
configuration Don't apply security.require-https to intracluster requests 2016-04-13 12:51:41 -07:00
exception Replace AphrontUsageException with AphrontMalformedRequestException 2015-09-03 10:04:17 -07:00
handler Modularize Aphront exception handling 2015-09-03 10:04:42 -07:00
httpparametertype Convert Countdown to EditEngine 2016-04-07 12:34:07 -07:00
interface Allow Controllers to return a wider range of "response-like" objects 2015-09-01 15:52:52 -07:00
response Reduce thumbnail flickering in comment previews 2016-04-06 15:52:52 -07:00
sink Extend from Phobject 2015-06-15 18:02:27 +10:00
site Don't apply security.require-https to intracluster requests 2016-04-13 12:51:41 -07:00
AphrontController.php Provide an AphrontController implementation of willSendResponse() 2015-09-07 17:18:35 -07:00
AphrontRequest.php When proxying cluster HTTP requests, forward only selected headers 2016-04-09 03:39:17 -07:00