1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-13 00:56:15 +01:00
phorge-phorge/src/applications/diffusion/remarkup
epriestley be235301d0 When commits have a "rewritten" hint, try to show that in handles in other applications
Summary:
Ref T11522. This tries to reduce the cost of rewriting a repository by making handles smarter about rewritten commits.

When a handle references an unreachable commit, try to load a rewrite hint for the commit. If we find one, change the handle name to "OldHash > NewHash" to provide a strong hint that the commit was rewritten and that copy/pasting the old hash (say, to the CLI) won't work.

I think this notation isn't totally self-evident, but users can click it to see the big error message on the page, and it's at least obvious that something weird is going on, which I think is the important part.

Some possible future work:

  - Not sure this ("Recycling Symbol") is the best symbol? Seems sort of reasonable but mabye there's a better one.
  - Putting this information directly on the hovercard could help explain what this means.

Test Plan: {F1780719}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11522

Differential Revision: https://secure.phabricator.com/D16437
2016-08-24 09:35:19 -07:00
..
__tests__ Stop all object mentions from matching after "@" 2015-09-29 06:43:49 -07:00
DiffusionCommitRemarkupRule.php When commits have a "rewritten" hint, try to show that in handles in other applications 2016-08-24 09:35:19 -07:00
DiffusionRepositoryByIDRemarkupRule.php make repo callsigns optional 2015-01-01 08:07:26 -08:00
DiffusionRepositoryRemarkupRule.php make repo callsigns optional 2015-01-01 08:07:26 -08:00