revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-27 09:12:41 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/webroot/rsrc/js/application/transactions
History
epriestley eaa883cf37 Fix anchor-clicking scroll positions 
Summary:
Fixes T7069. When jumping to a comment anchor, we get the scroll positions wrong.

Partly this is fixing some calcaulations; partly, the "show older comments" and "scroll anchor" stuff were fighting over the scroll position. Since the anchor can take care of things on its own, just let it handle stuff.

Test Plan:
  - Clicked comment anchors.
  - Loaded pages with anchors in the URI.
  - Loaded pages with anchors hidden behind "show older comments".

In all cases, got the right scroll position.

Reviewers: btrahan, chad

Reviewed By: chad

Subscribers: epriestley

Maniphest Tasks: T7069

Differential Revision: https://secure.phabricator.com/D11540
2015-01-28 08:26:10 -08:00
..
behavior-show-older-transactions.js Fix anchor-clicking scroll positions 2015-01-28 08:26:10 -08:00
behavior-transaction-comment-form.js Remove ajaxey comment magic in Pholio, and also some bugs 2014-06-21 12:50:40 -07:00
behavior-transaction-list.js Transactions - add "view raw" action 2014-08-07 15:21:32 -07:00