1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-10 08:52:39 +01:00
phorge-phorge/webroot/rsrc/js/application/projects
epriestley 61216dc641 Fix a JS error when adding a project card directly to a subproject from a workboard
Summary:
Fixes T12152. When creating a subproject task directly from a parent project, we can get column information back about the subproject column, which isn't visible. Just ignore this rather than trying to draw a card into a column which does not exist.

This flow (see test plan) is a little unintuitive since the card never appears on the workboard, but this class of things is probably roughly somewhere in T4900.

Test Plan:
  - Create a parent project A.
  - Create subproject B.
  - On the workboard for A, select "Create Task..." from the dropdown.
  - Add tag "B" in the dialog that pops up.
  - Save the task.

Note that this flow creates a task tagged only with "B", since "A" and "B" are mutually exclusive tags.

Before patch: UI freezes (JX.Mask is never removed), JS error in console.
After patch: workflow completes. Note that card is (correctly) not visible: it's in an invisible subproject column.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12152

Differential Revision: https://secure.phabricator.com/D17242
2017-01-24 07:41:32 -08:00
..
behavior-project-boards.js Attempt to make dropdown item actions more consistent 2017-01-18 13:14:54 -08:00
behavior-project-create.js Allow commits to be associated with projects and associated goodies 2012-08-08 10:03:41 -07:00
behavior-reorder-columns.js Allow the workboard backlog column to be reordered 2014-08-08 15:50:36 -07:00
WorkboardBoard.js Fix a JS error when adding a project card directly to a subproject from a workboard 2017-01-24 07:41:32 -08:00
WorkboardCard.js Restore column point counts to workboards 2016-02-10 14:01:28 -08:00
WorkboardColumn.js When summing points on a workboard, display sum with same precision as most-precise value 2016-09-27 09:36:46 -07:00
WorkboardController.js Fix an issue with creating tasks directly into milestone columns 2016-02-11 10:01:49 -08:00