1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-11 16:16:14 +01:00
phorge-phorge/webroot/rsrc/js/application/transactions
epriestley e187519f00 When a transaction has no quote ref, render "@user wrote:" properly
Summary:
Fixes T12576. In Javascript, `data.ref` is null, which is getting turned into `/quote/?ref=null`.

The code already handles this case, just not with `ref=null` happening in JS:

https://secure.phabricator.com/source/phabricator/browse/master/src/applications/transactions/controller/PhabricatorApplicationTransactionCommentQuoteController.php;b54adc6161c205e146fabb801ca53a44d94da444$47-52

Test Plan:
{F4913862}

  - Also quoted a normal comment on a normal object in a normal way.

Reviewers: amckinley, chad

Reviewed By: chad

Maniphest Tasks: T12576

Differential Revision: https://secure.phabricator.com/D17720
2017-04-18 09:51:53 -07:00
..
behavior-comment-actions.js Make Differential inline events actually trigger comment preview refreshes 2017-01-19 12:32:49 -08:00
behavior-reorder-configs.js Allow EditEngine create and edit forms to be reordered 2015-12-08 13:00:54 -08:00
behavior-reorder-fields.js Allow form configurations to retitle and reorder forms and add preambles 2015-11-22 15:12:57 -08:00
behavior-show-older-transactions.js Make links to hidden comments work (Fixes T11117) 2016-07-09 18:07:37 +10:00
behavior-transaction-comment-form.js Don't put a spacer line on the bottom of previews 2015-05-18 12:18:10 -07:00
behavior-transaction-list.js When a transaction has no quote ref, render "@user wrote:" properly 2017-04-18 09:51:53 -07:00