1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-02-08 21:08:29 +01:00
phorge-phorge/src/infrastructure
epriestley cbe9aea876 Enable log discard modes for all scripts
Summary:
Fixes T2273. We currently discard logs, service calls, etc., for daemons, but not for other scripts. However, other scripts may be long-running or issue a large body of service calls (e.g., `bin/search index --all`). We never retrieve this information from scripts (it is used to build darkconsole; in scripts, we echo it immediately under --trace), so discard it immediately to prevent these scripts from requiring a large amount of memory.

(When the daemons load `__init_script__.php` they end up calling this code, so this doesn't change anything for them. They hit another ServiceProfiler discard along the daemon pathways in libphutil, but the call is idempotent.)

Test Plan: Ran `bin/search index --all` and saw increasing memory usage before this patch, but steady memory usage after this patch.

Reviewers: btrahan, vrana, codeblock

Reviewed By: codeblock

CC: aran

Maniphest Tasks: T2273

Differential Revision: https://secure.phabricator.com/D4364
2013-01-08 15:54:08 -08:00
..
__tests__ Formalize configuration sources and source stacks 2012-12-25 06:44:29 -08:00
celerity Make timeline view prettier 2012-12-11 13:59:35 -08:00
daemon Enable log discard modes for all scripts 2013-01-08 15:54:08 -08:00
diff Make AphrontProxyResponse reduce to a real response instead of building a string 2012-12-11 17:27:25 -08:00
edges Modernize Macro application 2012-12-11 14:01:03 -08:00
env Enable log discard modes for all scripts 2013-01-08 15:54:08 -08:00
events Delete license headers from files 2012-11-05 11:16:51 -08:00
internationalization Translate setup issues 2013-01-03 19:05:13 -08:00
javelin Delete license headers from files 2012-11-05 11:16:51 -08:00
lint Delete license headers from files 2012-11-05 11:16:51 -08:00
markup Fix issue where "{Fnnn, size}" renders as though "size=full" 2013-01-02 14:03:29 -08:00
query Delete license headers from files 2012-11-05 11:16:51 -08:00
ssh Implement SSHD glue and Conduit SSH endpoint 2012-12-19 11:08:07 -08:00
storage Store width and height metadata of image files 2013-01-07 09:46:43 -08:00
testing Delete license headers from files 2012-11-05 11:16:51 -08:00
util Add PhabricatorHash::digestForIndex() 2012-12-21 05:43:33 -08:00
PhabricatorAccessLog.php Delete license headers from files 2012-11-05 11:16:51 -08:00
PhabricatorEditor.php Delete license headers from files 2012-11-05 11:16:51 -08:00
PhabricatorSetup.php Delete license headers from files 2012-11-05 11:16:51 -08:00