mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-16 03:42:41 +01:00
add7bc418d
Summary: Ref T3116. Add a Herald action "Require legal signatures" which requires revision authors to accept legal agreements before their revisions can be accepted. - Herald will check which documents the author has signed, and trigger a "you have to sign X, Y, Z" for other documents. - If the author has already signed everything, we don't spam the revision -- basically, this only triggers when signatures are missing. - The UI will show which documents must be signed and warn that the revision can't be accepted until they're completed. - Users aren't allowed to "Accept" the revision until documents are cleared. Fixes T1157. The original install making the request (Hive) no longer uses Phabricator, and this satisfies our requirements. Test Plan: - Added a Herald rule. - Created a revision, saw the rule trigger. - Viewed as author and non-author, saw field UI (generic for non-author, specific for author), transaction UI, and accept-warning UI. - Tried to accept revision. - Signed document, saw UI update. Note that signatures don't currently //push// an update to the revision, but could eventually (like blocking tasks work). - Accepted revision. - Created another revision, saw rules not add the document (since it's already signed, this is the "no spam" case). Reviewers: btrahan, chad Reviewed By: chad Subscribers: asherkin, epriestley Maniphest Tasks: T1157, T3116 Differential Revision: https://secure.phabricator.com/D9771 |
||
|---|---|---|
| .. | ||
| DifferentialApplyPatchField.php | ||
| DifferentialArcanistProjectField.php | ||
| DifferentialAsanaRepresentationField.php | ||
| DifferentialAuditorsField.php | ||
| DifferentialAuthorField.php | ||
| DifferentialBlameRevisionField.php | ||
| DifferentialBranchField.php | ||
| DifferentialChangesSinceLastUpdateField.php | ||
| DifferentialCommitsField.php | ||
| DifferentialConflictsField.php | ||
| DifferentialCoreCustomField.php | ||
| DifferentialCustomField.php | ||
| DifferentialDependenciesField.php | ||
| DifferentialDependsOnField.php | ||
| DifferentialEditPolicyField.php | ||
| DifferentialGitSVNIDField.php | ||
| DifferentialHostField.php | ||
| DifferentialJIRAIssuesField.php | ||
| DifferentialLintField.php | ||
| DifferentialManiphestTasksField.php | ||
| DifferentialPathField.php | ||
| DifferentialProjectReviewersField.php | ||
| DifferentialProjectsField.php | ||
| DifferentialRepositoryField.php | ||
| DifferentialRequiredSignaturesField.php | ||
| DifferentialRevertPlanField.php | ||
| DifferentialReviewedByField.php | ||
| DifferentialReviewersField.php | ||
| DifferentialRevisionIDField.php | ||
| DifferentialStoredCustomField.php | ||
| DifferentialSubscribersField.php | ||
| DifferentialSummaryField.php | ||
| DifferentialTestPlanField.php | ||
| DifferentialTitleField.php | ||
| DifferentialUnitField.php | ||
| DifferentialViewPolicyField.php | ||