1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-03 04:02:43 +01:00
phorge-phorge/src/applications/transactions
epriestley f8113aecdc Make bulk edit <select /> fields a little more natrual and set options for subtype transactions
Summary:
Ref T13025. This is some minor technical stuff: make the "select" bulk edit type a little more consistent with other types by passing data down instead of having it reach up the stack. This simplifies the implementation of a custom field "select" in a future change.

Also, provide an option list to the "select" edit field for object subtypes. This is only accessible via Conduit so it currently never actually renders anything in the UI, but with the bulk edit stuff we get some initialization order issues if we don't set anything. This will also make any future changes which expose subtypes more broadly more straightforward.

Test Plan:
  - Bulk edited "select" fields, like "Status" and "Priority".
  - No more fatal when trying to `getOptions()` internally on the subtype field.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13025

Differential Revision: https://secure.phabricator.com/D18878
2018-01-19 13:17:28 -08:00
..
application Allow EditEngine forms for objects which support subtyping to have a subtype configured 2017-03-02 04:18:06 -08:00
bulk Make bulk edit <select /> fields a little more natrual and set options for subtype transactions 2018-01-19 13:17:28 -08:00
commentaction When accepting revisions, allow users to accept on behalf of a subset of reviewers 2017-03-22 14:25:04 -07:00
conduit Provide some more detailed information about inline comments in "transaction.search" 2017-08-24 15:26:50 -07:00
constants When an object which supports subtypes is created, set its subtype to the creating form's subtype 2017-03-02 04:18:23 -08:00
controller Remove duplicate "Change Default Values" action in form editing workflow 2017-03-22 09:50:38 -07:00
data Don't re-mention users for comment edits 2016-06-13 13:57:59 -07:00
draft Show yellow "draft" bubble in Audit 2017-01-16 10:28:59 -08:00
edges Add a generic "edge.search" method 2017-03-04 15:26:29 -08:00
editengine Fix a bug with setting custom PHID list field values via Conduit and prepare for bulk edits 2018-01-19 12:51:35 -08:00
editfield Make bulk edit <select /> fields a little more natrual and set options for subtype transactions 2018-01-19 13:17:28 -08:00
editor Fix a minor/harmless race with feed publishers in certain draft states 2018-01-04 08:14:55 -08:00
edittype Fix a bug with setting custom PHID list field values via Conduit and prepare for bulk edits 2018-01-19 12:51:35 -08:00
engineextension Make bulk edit <select /> fields a little more natrual and set options for subtype transactions 2018-01-19 13:17:28 -08:00
error Allow users to unset "Editor", tailor short error messages properly on settings forms 2016-06-05 14:03:02 -07:00
exception Mark some strings for translation 2015-06-09 23:06:52 +10:00
feed Add AuthorHref to feed story images 2017-02-07 10:09:00 -08:00
interface Transactions - adding willRenderTimeline to handle tricky cases 2014-12-04 13:58:52 -08:00
phid Allow ApplicationEditor forms to be reconfigured 2015-11-10 10:24:40 -08:00
query Fix transaction queries using withComments() for transactions with no comments 2017-10-02 09:09:53 -07:00
replyhandler Modularize content sources 2016-03-26 11:59:45 -07:00
response Make inline comment preview and submission mostly work on EditEngine 2016-12-31 10:10:29 -08:00
storage Fix an issue where "Close Revision" did not appear in the UI 2017-08-29 09:58:48 -07:00
typeahead Don't allow forms which can't create objects to be added to profile menus 2017-02-16 15:45:11 -08:00
view Use Log In vs. Login when it's a verb 2017-08-02 12:26:47 -07:00
worker Cache user notification and message counts 2016-06-05 08:52:43 -07:00
xaction Modularize application transactions in Paste, mostly 2016-06-14 06:13:28 -07:00