mirror of
https://we.phorge.it/source/phorge.git
synced 2024-09-22 18:28:47 +02:00
ae7488f710
Summary: When rendering commit messages, drive all the logic through field specification classes instead of the hard-coded DifferentialCommitMessageData class. This removes DifferentialCommitMessageData and support classes. Note that this effectively reverts D546, and will cause a minor break for Facebook (Task IDs will no longer render in commit messages generated by "arc amend", and will not be editable via "arc diff --edit"). This can be resolved by implementing the feature as a custom field. While I've been able to preserve the task ID functionality elsewhere, I felt this implementation was too complex to reasonably leave hooks for, and the break is pretty minor. Test Plan: - Made numerous calls to differential.getcommitmessage across many diffs in various states, with and without 'edit' and with and without various field overrides. - General behavior seems correct (messages look accurate, and have the expected information). Special fields like "Reviewed By" and "git-svn-id" seem to work correctly. - Edit behavior seems correct (edit mode shows all editable fields, hides fields like "Reviewed By"). - Field overwrite behavior seems correct (overwritable fields show the correct values when overwritten, ignore provided values otherwise). Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, jungejason Differential Revision: 814
106 lines
2.4 KiB
PHP
106 lines
2.4 KiB
PHP
<?php
|
|
|
|
/*
|
|
* Copyright 2011 Facebook, Inc.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
final class DifferentialRevertPlanFieldSpecification
|
|
extends DifferentialFieldSpecification {
|
|
|
|
private $value;
|
|
|
|
public function getStorageKey() {
|
|
return 'phabricator:revert-plan';
|
|
}
|
|
|
|
public function getValueForStorage() {
|
|
return $this->value;
|
|
}
|
|
|
|
public function setValueFromStorage($value) {
|
|
$this->value = $value;
|
|
return $this;
|
|
}
|
|
|
|
public function shouldAppearOnEdit() {
|
|
return true;
|
|
}
|
|
|
|
public function setValueFromRequest(AphrontRequest $request) {
|
|
$this->value = $request->getStr($this->getStorageKey());
|
|
return $this;
|
|
}
|
|
|
|
public function renderEditControl() {
|
|
return id(new AphrontFormTextAreaControl())
|
|
->setLabel('Revert Plan')
|
|
->setName($this->getStorageKey())
|
|
->setCaption('Special steps required to safely revert this change.')
|
|
->setValue($this->value);
|
|
}
|
|
|
|
public function validateField() {
|
|
return;
|
|
}
|
|
|
|
public function shouldAppearOnRevisionView() {
|
|
return true;
|
|
}
|
|
|
|
public function renderLabelForRevisionView() {
|
|
return 'Revert Plan:';
|
|
}
|
|
|
|
public function renderValueForRevisionView() {
|
|
if (!$this->value) {
|
|
return null;
|
|
}
|
|
return phutil_escape_html($this->value);
|
|
}
|
|
|
|
public function shouldAppearOnConduitView() {
|
|
return true;
|
|
}
|
|
|
|
public function getValueForConduit() {
|
|
return $this->value;
|
|
}
|
|
|
|
public function shouldAppearOnCommitMessage() {
|
|
return true;
|
|
}
|
|
|
|
public function getCommitMessageKey() {
|
|
return 'revertPlan';
|
|
}
|
|
|
|
public function setValueFromParsedCommitMessage($value) {
|
|
$this->value = $value;
|
|
return $this;
|
|
}
|
|
|
|
public function shouldOverwriteWhenCommitMessageIsEdited() {
|
|
return true;
|
|
}
|
|
|
|
public function renderLabelForCommitMessage() {
|
|
return 'Revert Plan';
|
|
}
|
|
|
|
public function renderValueForCommitMessage($is_edit) {
|
|
return $this->value;
|
|
}
|
|
|
|
}
|