1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-26 08:42:41 +01:00
phorge-phorge/resources
epriestley aea46e55da Fix an issue where "Request Review" of a fully-accepted revision would transition to "Accepted"
Summary:
Ref T10967. This is explained in more detail in T10967#217125

When an author does "Request Review" on an accepted revision, void (in the sense of "cancel out", like a bank check) any "accepted" reviewers on the current diff.

Test Plan:
  - Create a revision with author A and reviewer B.
  - Accept as B.
  - "Request Review" as A.
  - (With sticky accepts enabled.)
  - Before patch: revision swithced back to "accepted".
  - After patch: the earlier review is "voided" by te "Request Review", and the revision switches to "Review Requested".

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10967

Differential Revision: https://secure.phabricator.com/D17566
2017-03-28 11:50:15 -07:00
..
builtin Allow custom image generation when choosing a profile image 2017-03-03 20:21:31 -08:00
celerity Scope syntax css rules to direct descendants only in diffs 2017-03-27 10:25:37 -07:00
chatbot Updated the docs so chatbots can use the Conduit API 2016-08-24 19:05:30 -04:00
cows Use PHP implementation of Cowsay for cowsay rule 2015-09-13 12:27:30 -07:00
emoji Add some sort of sort to Emoji Autocomplete 2017-01-24 20:21:06 -08:00
figlet/custom Include "Figlet" and PEAR "Text_Figlet" in externals 2015-09-13 12:30:48 -07:00
font Made Meme Generator 2013-01-19 18:43:43 -08:00
sprite Remove the Persona login method 2016-12-05 15:57:15 -08:00
sql Fix an issue where "Request Review" of a fully-accepted revision would transition to "Accepted" 2017-03-28 11:50:15 -07:00
sshd Improve Diffusion hosting setup instructions somewhat? 2016-04-26 10:06:59 -07:00