mirror of
https://we.phorge.it/source/phorge.git
synced 2024-09-22 18:28:47 +02:00
559c0fe886
Summary: Fixes T3471. Specific issues: - Add the ability to set a temporary cookie (expires when the browser closes). - We overwrote 'phcid' on every page load. This creates some issues with browser extensions. Instead, only write it if isn't set. To counterbalance this, make it temporary. - Make the 'next_uri' cookie temporary. - Make the 'phreg' cookie temporary. - Fix an issue where deleted cookies would persist after 302 (?) in some cases (this is/was 100% for me locally). Test Plan: - Closed my browser, reopned it, verified temporary cookies were gone. - Logged in, authed, linked, logged out. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T3471 Differential Revision: https://secure.phabricator.com/D8537
133 lines
3.4 KiB
PHP
133 lines
3.4 KiB
PHP
<?php
|
|
|
|
final class PhabricatorAuthLinkController
|
|
extends PhabricatorAuthController {
|
|
|
|
private $action;
|
|
private $providerKey;
|
|
|
|
public function willProcessRequest(array $data) {
|
|
$this->providerKey = $data['pkey'];
|
|
$this->action = $data['action'];
|
|
}
|
|
|
|
public function processRequest() {
|
|
$request = $this->getRequest();
|
|
$viewer = $request->getUser();
|
|
|
|
$provider = PhabricatorAuthProvider::getEnabledProviderByKey(
|
|
$this->providerKey);
|
|
if (!$provider) {
|
|
return new Aphront404Response();
|
|
}
|
|
|
|
switch ($this->action) {
|
|
case 'link':
|
|
if (!$provider->shouldAllowAccountLink()) {
|
|
return $this->renderErrorPage(
|
|
pht('Account Not Linkable'),
|
|
array(
|
|
pht('This provider is not configured to allow linking.'),
|
|
));
|
|
}
|
|
break;
|
|
case 'refresh':
|
|
if (!$provider->shouldAllowAccountRefresh()) {
|
|
return $this->renderErrorPage(
|
|
pht('Account Not Refreshable'),
|
|
array(
|
|
pht('This provider does not allow refreshing.'),
|
|
));
|
|
}
|
|
break;
|
|
default:
|
|
return new Aphront400Response();
|
|
}
|
|
|
|
$account = id(new PhabricatorExternalAccount())->loadOneWhere(
|
|
'accountType = %s AND accountDomain = %s AND userPHID = %s',
|
|
$provider->getProviderType(),
|
|
$provider->getProviderDomain(),
|
|
$viewer->getPHID());
|
|
|
|
switch ($this->action) {
|
|
case 'link':
|
|
if ($account) {
|
|
return $this->renderErrorPage(
|
|
pht('Account Already Linked'),
|
|
array(
|
|
pht(
|
|
'Your Phabricator account is already linked to an external '.
|
|
'account for this provider.'),
|
|
));
|
|
}
|
|
break;
|
|
case 'refresh':
|
|
if (!$account) {
|
|
return $this->renderErrorPage(
|
|
pht('No Account Linked'),
|
|
array(
|
|
pht(
|
|
'You do not have a linked account on this provider, and thus '.
|
|
'can not refresh it.'),
|
|
));
|
|
}
|
|
break;
|
|
default:
|
|
return new Aphront400Response();
|
|
}
|
|
|
|
$panel_uri = '/settings/panel/external/';
|
|
|
|
PhabricatorCookies::setClientIDCookie($request);
|
|
|
|
switch ($this->action) {
|
|
case 'link':
|
|
$form = $provider->buildLinkForm($this);
|
|
break;
|
|
case 'refresh':
|
|
$form = $provider->buildRefreshForm($this);
|
|
break;
|
|
default:
|
|
return new Aphront400Response();
|
|
}
|
|
|
|
if ($provider->isLoginFormAButton()) {
|
|
require_celerity_resource('auth-css');
|
|
$form = phutil_tag(
|
|
'div',
|
|
array(
|
|
'class' => 'phabricator-link-button pl',
|
|
),
|
|
$form);
|
|
}
|
|
|
|
switch ($this->action) {
|
|
case 'link':
|
|
$name = pht('Link Account');
|
|
$title = pht('Link %s Account', $provider->getProviderName());
|
|
break;
|
|
case 'refresh':
|
|
$name = pht('Refresh Account');
|
|
$title = pht('Refresh %s Account', $provider->getProviderName());
|
|
break;
|
|
default:
|
|
return new Aphront400Response();
|
|
}
|
|
|
|
$crumbs = $this->buildApplicationCrumbs();
|
|
$crumbs->addTextCrumb(pht('Link Account'), $panel_uri);
|
|
$crumbs->addTextCrumb($provider->getProviderName($name));
|
|
|
|
return $this->buildApplicationPage(
|
|
array(
|
|
$crumbs,
|
|
$form,
|
|
),
|
|
array(
|
|
'title' => $title,
|
|
'device' => true,
|
|
));
|
|
}
|
|
|
|
}
|