1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-02-05 11:28:25 +01:00
phorge-phorge/src/applications/differential
epriestley af06bfb1cc Make Changeset ID for render cache explicit
Summary:
DifferentialChangesetParser currently takes the Changeset object to mean a bunch
of different and mutually conflicting things implicitly:

  - Changeset ID is used to access the render cache.
  - Changeset ID is also used to tell the ajax endpoint what to render when
clicking "show more".
  - Changeset object has the actual changes.
  - Changeset ID and "oldChangesetID" are used to choose where to show inline
comments and how to attach new ones.

This indirectly causes a bunch of problems, like T141 and T132. Move toward
making all these separate things explicit. I want to have the changeset object
only mean the actual changes to display.

Test Plan:
Looked at changesets and verified the render cache was accessed correctly (and
not accessed in other cases).

Reviewed By: tuomaspelkonen
Reviewers: jungejason, tuomaspelkonen, aran
CC: aran, epriestley, tuomaspelkonen
Differential Revision: 228
2011-05-05 11:12:50 -07:00
..
constants Implemented "Plan Changes" action for differential. 2011-04-13 16:58:22 -07:00
controller Make Changeset ID for render cache explicit 2011-05-05 11:12:50 -07:00
data Faster Query for Differential Updates 2011-05-03 15:00:46 -07:00
editor Make X-Herald-Rules header sticky 2011-05-03 06:06:57 -07:00
mail Simplify and demuddle MetaMTA send pathways 2011-05-02 03:07:30 -07:00
parser Make Changeset ID for render cache explicit 2011-05-05 11:12:50 -07:00
storage Fix Differential "unsubscribe" so it properly blocks resubscription 2011-04-29 22:31:51 -07:00
tasks Enable updating task->revision assoc 2011-04-26 19:14:47 -07:00
view Modify whitespace default implementation 2011-04-28 09:22:02 -07:00