mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-04 04:32:43 +01:00
af295341c8
Summary: Ref T13130. See PHI251. Currently, changesets are marked as "generated" (i.e., the file contains generated code and does not normally need to be reviewed) at display time. An install would like support for having Owners rules ignore generated files. Additionally, future changes anticipate making "generated" and some other similar behaviors more flexible and more general. To support these, move toward a world where: - Changesets have "attributes": today, generated. In the future, perhaps: third-party, highlight-as, encoding, enormous-text-file, etc. - Attributes are either "trusted" (usually: the server assigned the attribute) or "untrusted" (usually: the client assigned the attribute). For attributes like "highlight-as", this isn't relevant, but I'd like to provide tools so that you can't make `arc` mark every file as "generated" and sneak past review rules in the future. Here, the `differential.generated-paths` config can mark a file as "generated" with a trusted attribute. The `@generated`-in-content rule can mark a file as "generated" with an untrusted attribute. Putting these attributes on changesets at creation time instead of display time will let Owners interact with changesets cheaply: it won't have to render an entire changeset just to figure out if it's generated or not. Test Plan: - Created a revision touching several files, some generated and some not. - Saw the generated files get marked properly with attribute metadata in the database, and show/fold as "Generated" in the UI. Reviewers: amckinley Reviewed By: amckinley Maniphest Tasks: T13130 Differential Revision: https://secure.phabricator.com/D19425 |
||
|---|---|---|
| .. | ||
| __tests__ | ||
| DifferentialAffectedPath.php | ||
| DifferentialChangeset.php | ||
| DifferentialCustomFieldNumericIndex.php | ||
| DifferentialCustomFieldStorage.php | ||
| DifferentialCustomFieldStringIndex.php | ||
| DifferentialDAO.php | ||
| DifferentialDiff.php | ||
| DifferentialDiffProperty.php | ||
| DifferentialDiffTransaction.php | ||
| DifferentialHiddenComment.php | ||
| DifferentialHunk.php | ||
| DifferentialInlineComment.php | ||
| DifferentialReviewer.php | ||
| DifferentialRevision.php | ||
| DifferentialSchemaSpec.php | ||
| DifferentialTransaction.php | ||
| DifferentialTransactionComment.php | ||