epriestley 42f1a95a12 Fix a flash of document selection when "oncopy" and "inline on range" behaviors interact ... Summary: Ref T13513. In Safari, do this: - view a 2-up diff with content on both sides; - select more than one line on the right side; and - use your mouse to click "New Inline Comment" in the context menu that pops up. The mousedown event for the "New Inline Comment" click removes the "copy selection" behavior and creates a flash where both sides of the diff are selected. This doesn't happen with (most) normal clicks because mouse down on a non-grabbable element clears the document selection. To avoid this, don't reset the copy selection behavior if the user mouses down on an "<a />". This might not be robust, but seems simple and plausible as a fix. Test Plan: - See above. - Before patch: flash of overbroad selection when clicking "New Inline Comment". - After patch: no selection flash. Maniphest Tasks: T13513 Differential Revision: https://secure.phabricator.com/D21254		2020-05-14 14:29:46 -07:00
..
darkconsole	Make the "Keyboard Shortcuts" dialog in Differential less hideous	2020-04-19 09:01:07 -07:00
behavior-audio-source.js
behavior-autofocus.js
behavior-badge-view.js	Links on badge card should be accessible	2016-04-15 07:55:31 -07:00
behavior-bulk-editor.js	Organize bulk edit actions into nice groups	2018-01-19 13:22:25 -08:00
behavior-choose-control.js	Allow installs to customize project icons	2016-01-08 14:01:53 -08:00
behavior-copy.js	Help PROFESSIONAL SOFTWARE ENGINEERS copy text to their clipboard	2017-05-31 10:13:49 -07:00
behavior-detect-timezone.js	When the JS "Intl" API is available, use it to guess the timezone	2016-05-22 09:14:02 -07:00
behavior-device.js	Fix spelling	2017-10-09 10:48:04 -07:00
behavior-drag-and-drop-textarea.js	Provide an <input type="file"> control in Remarkup for mobile and users with esoteric windowing systems	2016-05-20 16:24:22 -07:00
behavior-fancy-datepicker.js	Fix a hang in fancy date picker for Ye Olde Time Years	2017-08-10 08:48:44 -07:00
behavior-form.js
behavior-gesture.js
behavior-global-drag-and-drop.js	Allow users to drop .ics files on calendar views to import them	2016-10-18 15:26:44 -07:00
behavior-high-security-warning.js
behavior-history-install.js
behavior-hovercard.js	Move PhabricatorHovercard to PHUIHovercard	2016-02-03 16:26:30 +00:00
behavior-keyboard-pager.js
behavior-keyboard-shortcuts.js	Make the "Keyboard Shortcuts" dialog in Differential less hideous	2020-04-19 09:01:07 -07:00
behavior-lightbox-attachments.js	Fix image prev/next cycling in lightboxes	2018-03-08 08:28:04 -08:00
behavior-line-linker.js	Restore editor behavior to Diffusion and support "\" shortcut	2020-04-19 09:41:37 -07:00
behavior-linked-container.js	Replace the "Choose Subtype" radio buttons dialog with a simpler "big stuff you click" sort of UI	2018-12-10 14:59:18 -08:00
behavior-more.js
behavior-object-selector.js	Prevent object titles in the "Object Attacher" dialog from triggering Quicksand "Close Dialog on Navigation" behavior	2019-08-01 12:25:28 -07:00
behavior-oncopy.js	Fix a flash of document selection when "oncopy" and "inline on range" behaviors interact	2020-05-14 14:29:46 -07:00
behavior-phabricator-remarkup-assist.js	Make the "Keyboard Shortcuts" dialog in Differential less hideous	2020-04-19 09:01:07 -07:00
behavior-read-only-warning.js	When Phabricator is in read-only mode, explain why	2016-04-10 12:19:18 -07:00
behavior-redirect.js	Perform a client-side redirect after OAuth server authorization	2018-03-06 12:18:27 -08:00
behavior-refresh-csrf.js
behavior-remarkup-load-image.js	When proxying an "{image ...}" image fails, show the user an error message	2018-03-08 07:03:26 -08:00
behavior-remarkup-preview.js	Support field previews in EditEngine	2015-12-27 08:17:18 -08:00
behavior-reorder-applications.js
behavior-reveal-content.js
behavior-scrollbar.js
behavior-search-typeahead.js	Add a rough Quick Search datasource for Phriction documents	2018-02-16 09:55:54 -08:00
behavior-select-content.js	Clean up display of clone URIs a little bit	2016-05-11 13:14:55 -07:00
behavior-select-on-click.js
behavior-setup-check-https.js	Add client-side check for protocol mismatch	2016-06-07 15:54:48 +00:00
behavior-time-typeahead.js	Time controls should format end date value correctly (not 5:0 PM)	2016-04-15 12:18:12 -07:00
behavior-toggle-class.js	Activate "jx-toggle-class" on click to fix broken mobile behavior	2019-03-28 17:29:06 -07:00
behavior-tokenizer.js
behavior-tooltip.js	Redesign Home/Profile/Projects side navigation	2017-01-31 08:59:01 -08:00
behavior-user-menu.js	Make documentation items in user menu update as you navigate in Quicksand	2017-01-17 15:55:52 -08:00
behavior-watch-anchor.js	Fix a JS issue when the anchor element on a page has no container	2020-05-04 15:57:31 -07:00
behavior-workflow.js
Busy.js
DragAndDropFileUpload.js	Provide an <input type="file"> control in Remarkup for mobile and users with esoteric windowing systems	2016-05-20 16:24:22 -07:00
DraggableList.js	Prevent workboard cards from being grabbed by the "Txxx" object name text	2019-11-08 08:29:53 -08:00
Favicon.js	JX.Favicon for Conpherence	2016-10-20 12:17:50 -07:00
FileUpload.js	Support drag-and-drop to set cover images on workboard cards	2016-02-06 15:58:43 -08:00
Hovercard.js	Move PhabricatorHovercard to PHUIHovercard	2016-02-03 16:26:30 +00:00
KeyboardShortcut.js	Make the "Keyboard Shortcuts" dialog in Differential less hideous	2020-04-19 09:01:07 -07:00
KeyboardShortcutManager.js	Roughly style the new "flank" paths UI	2020-04-22 08:31:40 -07:00
MultirowRowManager.js
Notification.js	Correct the behavior of "Desktop Only" in Notifications preferences	2018-03-16 15:17:49 -07:00
phtize.js
Prefab.js	Show user availability dots (red = away, orange = busy) in typeaheads, tokenizer tokens, and autocompletes	2019-02-19 10:57:20 -08:00
ShapedRequest.js	Save drafts for inline comments currently being edited	2020-05-04 13:19:42 -07:00
TextAreaUtils.js	Provide an <input type="file"> control in Remarkup for mobile and users with esoteric windowing systems	2016-05-20 16:24:22 -07:00
Title.js	JX.Favicon for Conpherence	2016-10-20 12:17:50 -07:00
ToolTip.js	Make Differential objective markers show a brighter "editing" state	2017-05-20 07:57:38 -07:00