1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-11 17:32:41 +01:00
phorge-phorge/src/applications/auth/controller
Brian Cline b0802a7797 Resolve LDAP registration DAO exception due to empty username
Summary:
When logging in as an LDAP user for the first time (thus registering), a DAO exception was being thrown because PhabricatorLDAPRegistrationController wasn't passing in a username to PhabricatorUser::setUsername().

Somewhat separately, since either the PHP LDAP extension's underlying library or Active Directory are returning attributes with lowercased key names, I have to search on sAMAccountName and look for the key samaccountname in the results; this is fine since the config allows these to be defined separately. However I found that PhabricatorLDAPProvider::retrieveUserName() was attempting to use the search attribute rather than the username attribute. This resolves.

Test Plan: Tested registration and login against our internal AD infrastructure; worked perfectly. Need help from someone with access to a functional non-AD LDAP implementation; I've added the original author and CCs from D2722 in case they can help test in this regard.

Reviewers: epriestley, voldern

Reviewed By: voldern

CC: voldern, aran, Korvin, auduny, svemir

Differential Revision: https://secure.phabricator.com/D3340
2012-08-24 08:43:02 -07:00
..
oauthregistration T1354 : Resize profile pics (specifically to handle github v3 api) 2012-06-25 06:29:19 -07:00
PhabricatorAuthController.php Move files in Phabricator one level up 2012-06-01 12:32:44 -07:00
PhabricatorDisabledUserController.php Move files in Phabricator one level up 2012-06-01 12:32:44 -07:00
PhabricatorEmailLoginController.php Move files in Phabricator one level up 2012-06-01 12:32:44 -07:00
PhabricatorEmailTokenController.php Make settings panels more modular and modern 2012-08-13 12:37:26 -07:00
PhabricatorLDAPLoginController.php Make settings panels more modular and modern 2012-08-13 12:37:26 -07:00
PhabricatorLDAPRegistrationController.php Resolve LDAP registration DAO exception due to empty username 2012-08-24 08:43:02 -07:00
PhabricatorLDAPUnlinkController.php Make settings panels more modular and modern 2012-08-13 12:37:26 -07:00
PhabricatorLoginController.php Allow installs to configure an arbitrary block of HTML to show on the login screen 2012-08-14 19:11:46 -07:00
PhabricatorLoginValidateController.php Move files in Phabricator one level up 2012-06-01 12:32:44 -07:00
PhabricatorLogoutController.php Show a "Logout?" dialog when the user goes to /logout/ 2012-07-25 13:58:49 -07:00
PhabricatorMustVerifyEmailController.php Move files in Phabricator one level up 2012-06-01 12:32:44 -07:00
PhabricatorOAuthDiagnosticsController.php Get rid of file_get_contents($uri) 2012-06-18 17:45:45 -07:00
PhabricatorOAuthLoginController.php Make settings panels more modular and modern 2012-08-13 12:37:26 -07:00
PhabricatorOAuthUnlinkController.php Make settings panels more modular and modern 2012-08-13 12:37:26 -07:00
PhabricatorRefreshCSRFController.php Move files in Phabricator one level up 2012-06-01 12:32:44 -07:00