1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-02 11:42:42 +01:00
phorge-phorge/src/applications/harbormaster/worker
epriestley 5f774f7008 Stop build target start times from being overwritten on reentry
Summary:
See PHI615. Ref T13130. An install is reporting that "Lease Working Copy" build steps always report "Built instantly" after completion.

I'm not 100% sure that this is the fix, but I'm like 99% sure: "Lease Working Copy" build steps yield after they ask Drydock for a lease. They will later reenter `doWork()`, see that the lease is filled, and complete.

Right now, we reset the start time every time we enter `doWork()`. Instead, set it only if it hasn't been set yet.

Test Plan: This is low-risk and a bit tricky to reproduce locally, but I'll run some production builds and see what they look like.

Reviewers: amckinley

Reviewed By: amckinley

Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam

Maniphest Tasks: T13130

Differential Revision: https://secure.phabricator.com/D19412
2018-04-27 12:25:45 -07:00
..
HarbormasterBuildWorker.php Start buildables in "PREPARING", move them to "BUILDING" after builds queue 2018-02-12 12:18:29 -08:00
HarbormasterLogWorker.php As Harbormaster logs are processed, build a sparse map of byte offsets to line numbers 2018-02-26 17:56:52 -08:00
HarbormasterTargetWorker.php Stop build target start times from being overwritten on reentry 2018-04-27 12:25:45 -07:00
HarbormasterWorker.php Split Harbormaster workers apart so build steps can run in parallel 2014-01-06 12:32:10 -08:00