1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-15 11:22:40 +01:00
phorge-phorge/src/applications/differential/storage
epriestley 1da691113a Normalize the definition of "closed" revision statuses
Summary:
Currently, "Closed" and "Abandoned" are treated as "closed". I want to add a flag which treats "Accepted" as "Closed", too, for Asana and other companies who use an Asana-like workflow.

The background here is that their workflow is a bit weird. They basically do audits, but have a lot of things which Diffusion doesn't do well right now. This one change makes Differential fit their workflow fairly well, even though it's an audit workflow.

To prepare for this, normalize the definition of "closed" better. We have a few callsites which explicitly check for "ABANDONED || CLOSED", and normalizing this is cleaner anyway.

Also delete the very old COMMITTED status, which has been obsolete for over a year.

Test Plan: Browsed around most/all of the affected interfaces.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D7653
2013-11-25 17:39:24 -08:00
..
__tests__ re-factor DifferentialChangesetParser pass 3 / N 2013-01-09 13:11:17 -08:00
DifferentialAffectedPath.php Delete license headers from files 2012-11-05 11:16:51 -08:00
DifferentialAuxiliaryField.php Delete license headers from files 2012-11-05 11:16:51 -08:00
DifferentialChangeset.php Replace all "attach first..." exceptions with assertAttached() 2013-09-03 06:02:14 -07:00
DifferentialComment.php Reduce surface area of DifferentialComment API 2013-10-21 17:01:27 -07:00
DifferentialCustomFieldNumericIndex.php Add storage and classes for CustomField in Differential 2013-09-26 12:37:28 -07:00
DifferentialCustomFieldStorage.php Add storage and classes for CustomField in Differential 2013-09-26 12:37:28 -07:00
DifferentialCustomFieldStringIndex.php Add storage and classes for CustomField in Differential 2013-09-26 12:37:28 -07:00
DifferentialDAO.php Delete license headers from files 2012-11-05 11:16:51 -08:00
DifferentialDiff.php Assign PHIDs to all diffs 2013-11-06 13:59:06 -08:00
DifferentialDiffProperty.php Delete license headers from files 2012-11-05 11:16:51 -08:00
DifferentialHunk.php Adding support for 'adds' and 'removes' in diff content. 2013-10-04 06:37:39 -07:00
DifferentialInlineComment.php Migrate all Differential inline comments to ApplicationTransactions 2013-10-19 05:03:25 -07:00
DifferentialReviewer.php Move determination of reviewer authority into DifferentialRevisionQuery 2013-10-06 17:08:14 -07:00
DifferentialRevision.php Normalize the definition of "closed" revision statuses 2013-11-25 17:39:24 -08:00
DifferentialTransaction.php Remove getApplicationObjectTypeName from ApplicationTransactions 2013-08-21 12:32:06 -07:00
DifferentialTransactionComment.php Migrate all Differential inline comments to ApplicationTransactions 2013-10-19 05:03:25 -07:00