1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-22 21:40:55 +01:00
phorge-phorge/src/applications/search/menuitem
epriestley b2739710ba Don't allow forms which can't create objects to be added to profile menus
Summary:
Fixes T12281. Some forms (like Settings) can't actually create new objects. Currently, though, you can select them and add them to profile menus; if you do, they fail when building an item.

Kick them out of the typeahead, and decline to render them in menus.

Test Plan:
Added "Create Settings" to a menu, no longer fatals after patch (item vanished from menu, still editable normally to get rid of it).

Tried to add another "Create Settings", no longer available in typehaead.

Added some normal stuff.

Viewed a choose-among-forms dropdown in Maniphest, which still worked normally.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12281

Differential Revision: https://secure.phabricator.com/D17372
2017-02-16 15:45:11 -08:00
..
PhabricatorApplicationProfileMenuItem.php Fix a policy error for restricted applications in a profile menu 2017-02-04 07:08:49 -08:00
PhabricatorDashboardProfileMenuItem.php Replace ProfileMenu bugs with different bugs 2017-01-31 11:22:01 -08:00
PhabricatorDividerProfileMenuItem.php Add some style to label in Favorites Menu 2017-02-01 07:20:31 -08:00
PhabricatorEditEngineProfileMenuItem.php Don't allow forms which can't create objects to be added to profile menus 2017-02-16 15:45:11 -08:00
PhabricatorLabelProfileMenuItem.php Add Label MenuItem 2017-01-31 13:17:53 -08:00
PhabricatorLinkProfileMenuItem.php Validate menu item fields (links, projects, dashboards, applications, forms, etc) 2017-01-20 11:58:25 -08:00
PhabricatorManageProfileMenuItem.php Replace ProfileMenu bugs with different bugs 2017-01-31 11:22:01 -08:00
PhabricatorMotivatorProfileMenuItem.php Add back the motivator panel 2017-02-08 09:09:30 -08:00
PhabricatorProfileMenuItem.php Allow menu items to render their own content; make Dashboard items render on-page 2017-01-26 12:57:03 -08:00
PhabricatorProfileMenuItemIconSet.php Rename all ProfilePanels into ProfileMenuItems 2016-12-11 11:44:38 -08:00
PhabricatorProjectProfileMenuItem.php Minor consistency/order updates for menu items which reference other objects 2017-01-20 11:58:39 -08:00