revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-03 04:02:43 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications/metamta/controller
History
epriestley b2890eeb0e Add "final" to all Phabricator "Controller" classes 
Summary:
These are all unambiguously unextensible. Issues I hit:

  - Maniphest Change/Diff controllers, just consolidated them.
  - Some search controllers incorrectly extend from "Search" but should extend from "SearchBase". This has no runtime effects.
  - D1836 introduced a closure, which we don't handle correctly (somewhat on purpose; we target PHP 5.2). See T962.

Test Plan: Ran "testEverythingImplemented" unit test to identify classes extending from `final` classes. Resolved issues.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran, epriestley

Maniphest Tasks: T795

Differential Revision: https://secure.phabricator.com/D1843
2012-03-09 15:46:25 -08:00
..
base Lock down MetaMTA functionality to administrators 2011-12-30 14:37:13 -08:00
list Add "final" to all Phabricator "Controller" classes 2012-03-09 15:46:25 -08:00
mailinglistedit Add "final" to all Phabricator "Controller" classes 2012-03-09 15:46:25 -08:00
mailinglists Add "final" to all Phabricator "Controller" classes 2012-03-09 15:46:25 -08:00
receive Add "final" to all Phabricator "Controller" classes 2012-03-09 15:46:25 -08:00
receivedlist Add "final" to all Phabricator "Controller" classes 2012-03-09 15:46:25 -08:00
send Add "final" to all Phabricator "Controller" classes 2012-03-09 15:46:25 -08:00
sendgridreceive Add "final" to all Phabricator "Controller" classes 2012-03-09 15:46:25 -08:00
view Add "final" to all Phabricator "Controller" classes 2012-03-09 15:46:25 -08:00