1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-28 09:42:41 +01:00
phorge-phorge/src/applications/diffusion
epriestley b2b739c709 Reduce code duplication in Herald fields
Summary:
Ref T8726. I want to modularize values and reduce how hard-coded / copypasta'd they are.

  - Rename `get...StandardCondition()` to `get...StandardType()`, since we can drive both conditions and values from it.
  - Rename `STANDARD_LIST` to `STANDARD_PHID_LIST` for consistency: all "lists" are lists of PHIDs.
  - For all standard types which don't require typehaeads, lift their logic into the base class.
  - I'll lift typeaheads soon, but need to generalize them first.

Test Plan: Edited various Herald rules, saw value UI generate correctly.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T8726

Differential Revision: https://secure.phabricator.com/D13612
2015-07-16 14:11:44 -07:00
..
application Show when objects have a non-default policy 2015-06-22 11:46:59 -07:00
capability Simplify the implementation of PhabricatorPolicyCapability subclasses 2014-07-25 08:25:42 +10:00
conduit Reduce badness in viewing large files in the Diffusion web UI 2015-06-18 13:06:01 -07:00
config Improve UX for Diffusion mail fields 2015-05-25 07:18:48 -07:00
controller Use standard project rendering in Diffusion 2015-07-08 07:00:17 -07:00
data Extend from Phobject 2015-06-15 18:02:27 +10:00
doorkeeper Partially modernize Doorkeeper/Asana bridge 2014-10-01 07:09:34 -07:00
edge Fix reverting commit language 2015-06-01 09:54:30 +10:00
engine phtize all the things 2015-05-22 21:16:39 +10:00
events Migrate Differential revision edges to use modern EdgeType subclasses 2015-01-01 15:07:03 +11:00
exception phtize all the things 2015-05-22 21:16:39 +10:00
herald Reduce code duplication in Herald fields 2015-07-16 14:11:44 -07:00
panel Add "Mailing List" users 2015-06-03 18:42:33 -07:00
protocol Extend from Phobject 2015-06-15 18:02:27 +10:00
query Add an "--importing" flag to bin/repository reparse 2015-06-20 05:25:44 -07:00
remarkup make repo callsigns optional 2015-01-01 08:07:26 -08:00
request Extend from Phobject 2015-06-15 18:02:27 +10:00
response Allow Phabricator to serve Mercurial repositories over HTTP 2013-11-06 18:00:42 -08:00
ssh Extend from Phobject 2015-06-15 18:02:27 +10:00
symbol Extend from Phobject 2015-06-15 18:02:27 +10:00
typeahead Remove arcanist project datasource 2015-05-26 07:10:10 +10:00
view [Redesign] Move basefont to Lato, remove Source Sans Pro 2015-06-13 20:32:45 +01:00
DiffusionLintSaveRunner.php Extend from Phobject 2015-06-15 18:02:27 +10:00