1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-28 09:42:41 +01:00
phorge-phorge/src/applications/differential
epriestley b2d280ff51 Port comments through time and space in the common/best case
Summary:
Ref T7447. This ports comments forward and backward in the best case:

  - The old comment is on a changeset with the same filename.
  - The old and new files are pretty much the same, line-for-line.

This will fail to port a lot of comments around and probably port a lot of comments into goofy places. We can see how bad it is in practice.

Errata:

  - Design is me cobbling something together, probably worth tweaking.
  - "Old Comment" should, at a minimum, say "Newer Comment" sometimes, or we should come up with some better name for this stuff.

Test Plan: {F377214}

Reviewers: chad, btrahan

Reviewed By: btrahan

Subscribers: johnny-bit, yelirekim, epriestley

Maniphest Tasks: T7447

Differential Revision: https://secure.phabricator.com/D12484
2015-04-21 11:06:44 -07:00
..
__tests__ Show a more tailored message when adding empty files 2015-03-09 10:27:18 -07:00
application Fix some odd looking arrays 2015-04-05 22:29:39 +10:00
capability Simplify the implementation of PhabricatorPolicyCapability subclasses 2014-07-25 08:25:42 +10:00
command Generate mail command documentation from active commands 2015-04-01 11:51:47 -07:00
conduit Give Conduit params/return/errors protected visibility 2015-04-13 11:58:35 -07:00
config Remove all application-specific reply handler class overrides 2015-03-31 17:22:01 -07:00
constants Differential - label unit / lint results from the commit diff as not applicable 2014-09-16 12:11:54 -07:00
controller Port comments through time and space in the common/best case 2015-04-21 11:06:44 -07:00
customfield Convert all tokenizers to take token/scalar inputs 2015-03-31 14:10:55 -07:00
doorkeeper Partially modernize Doorkeeper/Asana bridge 2014-10-01 07:09:34 -07:00
edge Don't write inverse edges for DifferentialRevisionHasReviewerEdgeType 2015-01-04 10:07:56 +11:00
editor Allow "send me an email" in personal rules to punch through settings 2015-04-06 10:01:32 -07:00
event Remove implode_selected_handle_links() 2015-03-31 05:48:20 -07:00
exception Remove an unused class 2015-01-03 09:07:32 +11:00
garbagecollector Complete modularization of the GC daemon 2014-01-15 10:02:31 -08:00
landing Explicitly declare method/property visibility 2015-01-12 08:18:13 +11:00
lipsum Remove an unused variable 2015-01-03 10:31:46 +11:00
mail Fix some odd looking arrays 2015-04-05 22:29:39 +10:00
management Rename DifferentialHunk subclasses for consistency 2015-01-23 07:17:04 +11:00
parser Provide getObjectOwnerPHID() on inline comment views 2015-03-27 11:23:10 -07:00
phid Rename PHIDType classes 2014-07-24 08:05:46 +10:00
query Port comments through time and space in the common/best case 2015-04-21 11:06:44 -07:00
remarkup Rename PhutilRemarkupRule subclasses 2014-08-05 00:55:43 +10:00
render Touch up PHP/JS interactions for inline comments 2015-03-27 17:08:31 -07:00
search Rename PHIDType classes 2014-07-24 08:05:46 +10:00
storage Port comments through time and space in the common/best case 2015-04-21 11:06:44 -07:00
view Require TokenizerControl to always have a datasource 2015-04-20 10:06:13 -07:00
DifferentialGetWorkingCopy.php Applied various linter fixes. 2014-06-09 16:04:12 -07:00