1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-28 16:30:59 +01:00
phorge-phorge/src/applications/differential
epriestley b3397030e6 Fix Differential "unsubscribe" so it properly blocks resubscription
Summary:
DifferentialRevision stores this field as a dictionary but the
Editor incorrectly passed it to Herald as a raw value array. Ideally the
property should be called unsubscribedDict or something but I'm increasingly
thinking we're going to centralize subscriptions for Adjutant or some similar
system so I'm disinclined to pursue the schema change just yet. I provided an
explicit raw-value-oriented API, at least.

Test Plan:
With two accounts, A and B: created universal Herald CC rule with
user B, created a revision with user A, had user B unsubscribe, had user A
update the revision. User B was not resubscribed.

Reviewed By: aran
Reviewers: jungejason, tuomaspelkonen, aran
CC: ola, aran, epriestley
Differential Revision: 188
2011-04-29 22:31:51 -07:00
..
constants Implemented "Plan Changes" action for differential. 2011-04-13 16:58:22 -07:00
controller Fix XSS hole in inline comment editing 2011-04-29 20:27:25 -07:00
data Differential Updates View 2011-04-28 14:40:41 -07:00
editor Fix Differential "unsubscribe" so it properly blocks resubscription 2011-04-29 22:31:51 -07:00
mail Don't send a blank "COMMITS" field for mark-committed revisions. 2011-04-10 14:36:04 -07:00
parser Differential whitespace mode IGNORE ALL now shows correct indentation 2011-04-28 16:10:59 -07:00
storage Fix Differential "unsubscribe" so it properly blocks resubscription 2011-04-29 22:31:51 -07:00
tasks Enable updating task->revision assoc 2011-04-26 19:14:47 -07:00
view Modify whitespace default implementation 2011-04-28 09:22:02 -07:00