mirror of
https://we.phorge.it/source/phorge.git
synced 2025-03-13 21:05:02 +01:00
Summary: `strlen()` was used in Phabricator to check if a generic value is a non-empty string. This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement. Note: this may highlight other absurd input values that might be worth correcting instead of just ignoring. If phutil_nonempty_string() throws an exception in your instance, report it to Phorge to evaluate and fix that specific corner case. ``` EXCEPTION: (RuntimeException) strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [<arcanist>/src/error/PhutilErrorHandler.php:261] arcanist(head=master, ref.master=b325304b6e52), phorge(head=HgViewBranches, ref.master=cb938d869c3f, ref.HgViewBranches=cb938d869c3f) #0 <#2> PhutilErrorHandler::handleError(integer, string, string, integer) called at [<phorge>/src/applications/diffusion/conduit/DiffusionBranchQueryConduitAPIMethod.php:83] ``` Closes T15447 Test Plan: After applying this change, going to `/diffusion/1/branches/default/` shows an expected FilesystemException instead of the previous RuntimeException. Reviewers: O1 Blessed Committers, speck Reviewed By: O1 Blessed Committers, speck Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Maniphest Tasks: T15447 Differential Revision: https://we.phorge.it/D25279
136 lines
3.8 KiB
PHP
136 lines
3.8 KiB
PHP
<?php
|
|
|
|
final class DiffusionBranchQueryConduitAPIMethod
|
|
extends DiffusionQueryConduitAPIMethod {
|
|
|
|
public function getAPIMethodName() {
|
|
return 'diffusion.branchquery';
|
|
}
|
|
|
|
public function getMethodDescription() {
|
|
return pht('Determine what branches exist for a repository.');
|
|
}
|
|
|
|
protected function defineReturnType() {
|
|
return 'list<dict>';
|
|
}
|
|
|
|
protected function defineCustomParamTypes() {
|
|
return array(
|
|
'closed' => 'optional bool',
|
|
'limit' => 'optional int',
|
|
'offset' => 'optional int',
|
|
'contains' => 'optional string',
|
|
'patterns' => 'optional list<string>',
|
|
);
|
|
}
|
|
|
|
protected function getGitResult(ConduitAPIRequest $request) {
|
|
$drequest = $this->getDiffusionRequest();
|
|
$repository = $drequest->getRepository();
|
|
|
|
$contains = $request->getValue('contains');
|
|
if (phutil_nonempty_string($contains)) {
|
|
|
|
// See PHI958 (and, earlier, PHI720). If "patterns" are provided, pass
|
|
// them to "git branch ..." to let callers test for reachability from
|
|
// particular branch heads.
|
|
$patterns_argv = $request->getValue('patterns', array());
|
|
PhutilTypeSpec::checkMap(
|
|
array(
|
|
'patterns' => $patterns_argv,
|
|
),
|
|
array(
|
|
'patterns' => 'list<string>',
|
|
));
|
|
|
|
// NOTE: We can't use DiffusionLowLevelGitRefQuery here because
|
|
// `git for-each-ref` does not support `--contains`.
|
|
list($stdout) = $repository->execxLocalCommand(
|
|
'branch --verbose --no-abbrev --contains %s -- %Ls',
|
|
$contains,
|
|
$patterns_argv);
|
|
$ref_map = DiffusionGitBranch::parseLocalBranchOutput(
|
|
$stdout);
|
|
|
|
$refs = array();
|
|
foreach ($ref_map as $ref => $commit) {
|
|
$refs[] = id(new DiffusionRepositoryRef())
|
|
->setShortName($ref)
|
|
->setCommitIdentifier($commit);
|
|
}
|
|
} else {
|
|
$refs = id(new DiffusionLowLevelGitRefQuery())
|
|
->setRepository($repository)
|
|
->withRefTypes(
|
|
array(
|
|
PhabricatorRepositoryRefCursor::TYPE_BRANCH,
|
|
))
|
|
->execute();
|
|
}
|
|
|
|
return $this->processBranchRefs($request, $refs);
|
|
}
|
|
|
|
protected function getMercurialResult(ConduitAPIRequest $request) {
|
|
$drequest = $this->getDiffusionRequest();
|
|
$repository = $drequest->getRepository();
|
|
|
|
$query = id(new DiffusionLowLevelMercurialBranchesQuery())
|
|
->setRepository($repository);
|
|
|
|
$contains = $request->getValue('contains');
|
|
if (phutil_nonempty_string($contains)) {
|
|
$query->withContainsCommit($contains);
|
|
}
|
|
|
|
$refs = $query->execute();
|
|
|
|
return $this->processBranchRefs($request, $refs);
|
|
}
|
|
|
|
protected function getSVNResult(ConduitAPIRequest $request) {
|
|
// Since SVN doesn't have meaningful branches, just return nothing for all
|
|
// queries.
|
|
return array();
|
|
}
|
|
|
|
private function processBranchRefs(ConduitAPIRequest $request, array $refs) {
|
|
$drequest = $this->getDiffusionRequest();
|
|
$repository = $drequest->getRepository();
|
|
$offset = $request->getValue('offset');
|
|
$limit = $request->getValue('limit');
|
|
|
|
foreach ($refs as $key => $ref) {
|
|
if (!$repository->shouldTrackBranch($ref->getShortName())) {
|
|
unset($refs[$key]);
|
|
}
|
|
}
|
|
|
|
$with_closed = $request->getValue('closed');
|
|
if ($with_closed !== null) {
|
|
foreach ($refs as $key => $ref) {
|
|
$fields = $ref->getRawFields();
|
|
if (idx($fields, 'closed') != $with_closed) {
|
|
unset($refs[$key]);
|
|
}
|
|
}
|
|
}
|
|
|
|
// NOTE: We can't apply the offset or limit until here, because we may have
|
|
// filtered untrackable branches out of the result set.
|
|
|
|
if ($offset) {
|
|
$refs = array_slice($refs, $offset);
|
|
}
|
|
|
|
if ($limit) {
|
|
$refs = array_slice($refs, 0, $limit);
|
|
}
|
|
|
|
$refs = array_values($refs);
|
|
|
|
return mpull($refs, 'toDictionary');
|
|
}
|
|
|
|
}
|