1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-18 03:20:59 +01:00
phorge-phorge/src/view
epriestley 3a2c2ae3c3 Implement a scope selector for the global search
Summary:
See M1433. Fixes T7266. Fixes T4475. Ref T7314.

Future work/notes/etc:

  - Write the User Guide (see TODO).
  - This might needs some design tweaks -- I think it's functionally almost-equivalent to the mock, but the UI isn't quite the same.
  - (Mobile design is a touch off-looking I think?)
  - When you use a custom query, the duplicate "magnifying glass" icons are a little weird. Maybe change one or the other.
  - Maybe worth adding an "Open Documents in Current Application" option? Planning to wait for feedback on that.
  - Need a Quicksand integration to change the current application at some point.
  - Searching in "Current Application" from, e.g., the 404 page just searches all documents. Current plan is to just document this behavior, since the icon is a pretty good callout and it seems plausible that this is intuitive enough that users won't have a hard time with it.

Test Plan:
New dropdown:

{F379150}

Device-ish:

{F379151}

Normal search (current application, from maniphest, selects tasks):

{F379153}

Application search from non-application:

{F379154}

Reviewers: btrahan, chad

Reviewed By: chad

Subscribers: johnny-bit, epriestley

Maniphest Tasks: T7266, T7314, T4475

Differential Revision: https://secure.phabricator.com/D12509
2015-04-22 14:31:36 -07:00
..
__tests__ Smooth out Phortune purchase completion flow 2014-10-09 16:58:26 -07:00
control Make the browse button on the tokenizer, be on the tokenizer 2015-04-18 10:58:50 -07:00
form Move token rendering into Datasources 2015-04-20 10:06:14 -07:00
layout Conpherence - refactor display classes a bit 2015-04-14 12:25:35 -07:00
page Implement a scope selector for the global search 2015-04-22 14:31:36 -07:00
phui Add setEpoch for PHUIHeaderView, use in all Documents 2015-04-12 18:08:09 -07:00
widget Minor, touch up Exception rendering 2015-02-19 08:45:37 -08:00
AphrontDialogView.php Move PHUIErrorView to PHUIInfoView 2015-03-01 14:45:56 -08:00
AphrontJavelinView.php Partial fix for Javelin View Example 2013-07-16 13:31:43 -07:00
AphrontNullView.php Provide hasChildren() to replace isEmptyContent() 2013-08-12 07:51:01 -07:00
AphrontTagView.php Improve handle loading semantics for tokenizers 2015-04-02 13:42:01 -07:00
AphrontView.php Improve handle loading semantics for tokenizers 2015-04-02 13:42:01 -07:00
viewutils.php Remove unused phabricator_on_relative_date function 2015-01-05 06:38:38 +11:00