revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-15 19:32:40 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications/diffusion/controller
History
epriestley 56a9709008 Reduce code duplication for inline "Undo" 
Summary:
Ref T2009. This is another almost-identical copy of the row scaffolding, which has the same 1up/2up bugs as the 8 other copies of this code.

Turn the "undo" element into an InlineCommentView so we can scaffold it.

Then, scaffold it with the same code as everything else.

Test Plan: Hit "Undo", swapped from 1up to 2up, hit "undo" again, swapped back, tried left/right, everything rendered with proper scaffolding.

Reviewers: btrahan, chad

Reviewed By: chad

Subscribers: epriestley

Maniphest Tasks: T2009

Differential Revision: https://secure.phabricator.com/D12019
2015-03-09 10:26:53 -07:00
..
DiffusionBranchTableController.php Remove AphrontPanelView from Diffusion 2015-03-06 15:32:12 -08:00
DiffusionBrowseController.php Have DifferentialRevisionListView return ObjectBoxView 2015-02-19 08:11:17 -08:00
DiffusionBrowseDirectoryController.php Remove AphrontPanelView from Diffusion 2015-03-06 15:32:12 -08:00
DiffusionBrowseFileController.php Rename inline comment views to "PHUIDiff" and give them a base class 2015-03-06 15:00:14 -08:00
DiffusionBrowseMainController.php Diffusion - return 404 errors for bad URIs 2015-01-09 13:29:08 -08:00
DiffusionBrowseSearchController.php Diffusion - clean up catching ConduitException 2015-02-17 14:01:17 -08:00
DiffusionChangeController.php Diffusion - return 404 errors for bad URIs 2015-01-09 13:29:08 -08:00
DiffusionCommitBranchesController.php Diffusion - clean up catching ConduitException 2015-02-17 14:01:17 -08:00
DiffusionCommitController.php Change setErrorView to setInfoView in PHUIObjectBoxView 2015-03-06 17:03:18 -08:00
DiffusionCommitEditController.php Diffusion - return 404 errors for bad URIs 2015-01-09 13:29:08 -08:00
DiffusionCommitTagsController.php Diffusion - clean up catching ConduitException 2015-02-17 14:01:17 -08:00
DiffusionController.php Move PHUIErrorView to PHUIInfoView 2015-03-01 14:45:56 -08:00
DiffusionDiffController.php Reduce code duplication for inline "Undo" 2015-03-09 10:26:53 -07:00
DiffusionExternalController.php Change setErrorView to setInfoView in PHUIObjectBoxView 2015-03-06 17:03:18 -08:00
DiffusionHistoryController.php Remove AphrontPanelView from Diffusion 2015-03-06 15:32:12 -08:00
DiffusionInlineCommentController.php Explicitly track inline comment reply threading 2015-03-09 10:26:50 -07:00
DiffusionInlineCommentPreviewController.php Hide direct accesses to Audit inline comment table behind API 2014-07-24 17:59:28 -07:00
DiffusionLastModifiedController.php Diffusion - return 404 errors for bad URIs 2015-01-09 13:29:08 -08:00
DiffusionLintController.php Remove AphrontPanelView from Diffusion 2015-03-06 15:32:12 -08:00
DiffusionLintDetailsController.php Remove AphrontPanelView from Diffusion 2015-03-06 15:32:12 -08:00
DiffusionMirrorDeleteController.php Diffusion - return 404 errors for bad URIs 2015-01-09 13:29:08 -08:00
DiffusionMirrorEditController.php Move PHUIErrorView to PHUIInfoView 2015-03-01 14:45:56 -08:00
DiffusionPathCompleteController.php Diffusion - return 404 errors for bad URIs 2015-01-09 13:29:08 -08:00
DiffusionPathTreeController.php Diffusion - return 404 errors for bad URIs 2015-01-09 13:29:08 -08:00
DiffusionPathValidateController.php Diffusion - return 404 errors for bad URIs 2015-01-09 13:29:08 -08:00
DiffusionPushEventViewController.php Diffusion - return 404 errors for bad URIs 2015-01-09 13:29:08 -08:00
DiffusionPushLogController.php Diffusion - return 404 errors for bad URIs 2015-01-09 13:29:08 -08:00
DiffusionPushLogListController.php Diffusion - return 404 errors for bad URIs 2015-01-09 13:29:08 -08:00
DiffusionRepositoryController.php Move PHUIErrorView to PHUIInfoView 2015-03-01 14:45:56 -08:00
DiffusionRepositoryCreateController.php Set "importing" flag on repositories created via API 2015-03-04 10:36:09 -08:00
DiffusionRepositoryDefaultController.php Diffusion - return 404 errors for bad URIs 2015-01-09 13:29:08 -08:00
DiffusionRepositoryEditActionsController.php Diffusion - return 404 errors for bad URIs 2015-01-09 13:29:08 -08:00
DiffusionRepositoryEditActivateController.php Diffusion - return 404 errors for bad URIs 2015-01-09 13:29:08 -08:00
DiffusionRepositoryEditBasicController.php Diffusion - return 404 errors for bad URIs 2015-01-09 13:29:08 -08:00
DiffusionRepositoryEditBranchesController.php Diffusion - return 404 errors for bad URIs 2015-01-09 13:29:08 -08:00
DiffusionRepositoryEditController.php Fix method visibility for PhabricatorController subclasses 2015-01-07 07:34:59 +11:00
DiffusionRepositoryEditDangerousController.php Diffusion - return 404 errors for bad URIs 2015-01-09 13:29:08 -08:00
DiffusionRepositoryEditDeleteController.php Diffusion - return 404 errors for bad URIs 2015-01-09 13:29:08 -08:00
DiffusionRepositoryEditEncodingController.php Diffusion - return 404 errors for bad URIs 2015-01-09 13:29:08 -08:00
DiffusionRepositoryEditHostingController.php Diffusion - return 404 errors for bad URIs 2015-01-09 13:29:08 -08:00
DiffusionRepositoryEditMainController.php Improve visibility of repository credential errors 2015-02-19 10:32:25 -08:00
DiffusionRepositoryEditStorageController.php Diffusion - return 404 errors for bad URIs 2015-01-09 13:29:08 -08:00
DiffusionRepositoryEditSubversionController.php Diffusion - return 404 errors for bad URIs 2015-01-09 13:29:08 -08:00
DiffusionRepositoryEditUpdateController.php Diffusion - return 404 errors for bad URIs 2015-01-09 13:29:08 -08:00
DiffusionRepositoryListController.php Diffusion - return 404 errors for bad URIs 2015-01-09 13:29:08 -08:00
DiffusionRepositoryNewController.php Diffusion - return 404 errors for bad URIs 2015-01-09 13:29:08 -08:00
DiffusionServeController.php Proxy VCS HTTP requests 2015-01-27 14:51:09 -08:00
DiffusionSymbolController.php Remove AphrontPanelView from Diffusion 2015-03-06 15:32:12 -08:00
DiffusionTagListController.php Remove AphrontPanelView from Diffusion 2015-03-06 15:32:12 -08:00