1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-13 10:22:42 +01:00
phorge-phorge/src/applications/differential/view
epriestley b592630d72 Provide more structure to PHUIObjectBoxView
Summary:
Three changes here.

  - Add `setActionList()`, and use that to set the action list.
  - Add `setPropertyList()`, and use that to set the property list.

These will let us add some apropriate CSS so we can fix the border issue, and get rid of a bunch of goofy `.x + .y` selectors.

  - Replace `addContent()` with `appendChild()`.

This is just a consistency thing; `AphrontView` already provides `appendChild()`, and `addContent()` did the same thing.

Test Plan:
  - Viewed "All Config".
  - Viewed a countdown.
  - Viewed a revision (add comment, change list, table of contents, comment, local commits, open revisions affecting these files, update history).
  - Viewed Diffusion (browse, change, history, repository, lint).
  - Viewed Drydock (resource, lease).
  - Viewed Files.
  - Viewed Herald.
  - Viewed Legalpad.
  - Viewed macro (edit, edit audio, view).
  - Viewed Maniphest.
  - Viewed Applications.
  - Viewed Paste.
  - Viewed People.
  - Viewed Phulux.
  - Viewed Pholio.
  - Viewed Phame (blog, post).
  - Viewed Phortune (account, product).
  - Viewed Ponder (questions, answers, comments).
  - Viewed Releeph.
  - Viewed Projects.
  - Viewed Slowvote.

NOTE: Images in Files aren't on a black background anymore -- I assume that's on purpose?

NOTE: Some jankiness in Phortune, I'll clean that up when I get back to it. Not related to this diff.

Reviewers: chad

Reviewed By: chad

CC: aran

Differential Revision: https://secure.phabricator.com/D7174
2013-09-30 09:36:04 -07:00
..
DifferentialAddCommentView.php Provide more structure to PHUIObjectBoxView 2013-09-30 09:36:04 -07:00
DifferentialChangesetDetailView.php Remove all calls to renderSingleView() and deprecate it 2013-03-09 13:52:41 -08:00
DifferentialChangesetFileTreeSideNavBuilder.php Merge branch 'master' into phutil_tag 2013-02-05 10:23:16 -08:00
DifferentialChangesetListView.php Provide more structure to PHUIObjectBoxView 2013-09-30 09:36:04 -07:00
DifferentialDiffTableOfContentsView.php Provide more structure to PHUIObjectBoxView 2013-09-30 09:36:04 -07:00
DifferentialInlineCommentEditView.php Clean up inline edit ui 2013-05-09 16:09:29 -07:00
DifferentialInlineCommentView.php Restore merge of phutil_tag. 2013-02-13 14:51:18 -08:00
DifferentialLocalCommitsView.php Provide more structure to PHUIObjectBoxView 2013-09-30 09:36:04 -07:00
DifferentialPrimaryPaneView.php Restore merge of phutil_tag. 2013-02-13 14:51:18 -08:00
DifferentialResultsTableView.php render_tag -> tag: PropertyListView 2013-01-29 11:01:47 -08:00
DifferentialRevisionCommentListView.php Restore merge of phutil_tag. 2013-02-13 14:51:18 -08:00
DifferentialRevisionCommentView.php Remove all calls to renderSingleView() and deprecate it 2013-03-09 13:52:41 -08:00
DifferentialRevisionDetailView.php Provide more structure to PHUIObjectBoxView 2013-09-30 09:36:04 -07:00
DifferentialRevisionListView.php Move PhabricatorObjectItem to PHUIObjectItem, add 'plain' setting for lists. 2013-09-09 14:14:34 -07:00
DifferentialRevisionStatsView.php Remove line-related stats from Differential 2013-03-26 13:59:02 -07:00
DifferentialRevisionUpdateHistoryView.php Provide more structure to PHUIObjectBoxView 2013-09-30 09:36:04 -07:00