revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-26 07:20:57 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications/drydock
History
epriestley b592630d72 Provide more structure to PHUIObjectBoxView 
Summary:
Three changes here.

  - Add `setActionList()`, and use that to set the action list.
  - Add `setPropertyList()`, and use that to set the property list.

These will let us add some apropriate CSS so we can fix the border issue, and get rid of a bunch of goofy `.x + .y` selectors.

  - Replace `addContent()` with `appendChild()`.

This is just a consistency thing; `AphrontView` already provides `appendChild()`, and `addContent()` did the same thing.

Test Plan:
  - Viewed "All Config".
  - Viewed a countdown.
  - Viewed a revision (add comment, change list, table of contents, comment, local commits, open revisions affecting these files, update history).
  - Viewed Diffusion (browse, change, history, repository, lint).
  - Viewed Drydock (resource, lease).
  - Viewed Files.
  - Viewed Herald.
  - Viewed Legalpad.
  - Viewed macro (edit, edit audio, view).
  - Viewed Maniphest.
  - Viewed Applications.
  - Viewed Paste.
  - Viewed People.
  - Viewed Phulux.
  - Viewed Pholio.
  - Viewed Phame (blog, post).
  - Viewed Phortune (account, product).
  - Viewed Ponder (questions, answers, comments).
  - Viewed Releeph.
  - Viewed Projects.
  - Viewed Slowvote.

NOTE: Images in Files aren't on a black background anymore -- I assume that's on purpose?

NOTE: Some jankiness in Phortune, I'll clean that up when I get back to it. Not related to this diff.

Reviewers: chad

Reviewed By: chad

CC: aran

Differential Revision: https://secure.phabricator.com/D7174
2013-09-30 09:36:04 -07:00
..
application Added beta status for applications 2013-01-19 10:31:28 -08:00
blueprint Make most repository reads policy-aware 2013-09-25 16:54:48 -07:00
constants Improve Drydock's ability to allocate leases correctly 2012-12-12 18:42:12 -08:00
controller Provide more structure to PHUIObjectBoxView 2013-09-30 09:36:04 -07:00
interface Add HarbormasterRunnerWorker, for running CI tests 2012-12-17 13:43:26 -08:00
management Allow leases to be explicitly released via web or CLI 2012-12-14 15:42:58 -08:00
query Make most Drydock web interfaces work with mobile 2012-12-17 14:47:21 -08:00
storage Replace all "attach first..." exceptions with assertAttached() 2013-09-03 06:02:14 -07:00
util Improve Drydock's ability to allocate leases correctly 2012-12-12 18:42:12 -08:00
worker Add PhabricatorWorker->log() 2013-06-25 16:31:37 -07:00