revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-25 00:02:41 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications/macro
History
epriestley b592630d72 Provide more structure to PHUIObjectBoxView 
Summary:
Three changes here.

  - Add `setActionList()`, and use that to set the action list.
  - Add `setPropertyList()`, and use that to set the property list.

These will let us add some apropriate CSS so we can fix the border issue, and get rid of a bunch of goofy `.x + .y` selectors.

  - Replace `addContent()` with `appendChild()`.

This is just a consistency thing; `AphrontView` already provides `appendChild()`, and `addContent()` did the same thing.

Test Plan:
  - Viewed "All Config".
  - Viewed a countdown.
  - Viewed a revision (add comment, change list, table of contents, comment, local commits, open revisions affecting these files, update history).
  - Viewed Diffusion (browse, change, history, repository, lint).
  - Viewed Drydock (resource, lease).
  - Viewed Files.
  - Viewed Herald.
  - Viewed Legalpad.
  - Viewed macro (edit, edit audio, view).
  - Viewed Maniphest.
  - Viewed Applications.
  - Viewed Paste.
  - Viewed People.
  - Viewed Phulux.
  - Viewed Pholio.
  - Viewed Phame (blog, post).
  - Viewed Phortune (account, product).
  - Viewed Ponder (questions, answers, comments).
  - Viewed Releeph.
  - Viewed Projects.
  - Viewed Slowvote.

NOTE: Images in Files aren't on a black background anymore -- I assume that's on purpose?

NOTE: Some jankiness in Phortune, I'll clean that up when I get back to it. Not related to this diff.

Reviewers: chad

Reviewed By: chad

CC: aran

Differential Revision: https://secure.phabricator.com/D7174
2013-09-30 09:36:04 -07:00
..
application Allow macros to have associated audio and audio behaviors 2013-09-27 16:01:37 -07:00
conduit Adding macro create method. 2013-07-08 19:49:05 -07:00
config MetaMTA: Owners, Pholio, Macro 2013-01-16 10:52:30 -08:00
constants Allow macros to have associated audio and audio behaviors 2013-09-27 16:01:37 -07:00
controller Provide more structure to PHUIObjectBoxView 2013-09-30 09:36:04 -07:00
editor Allow macros to have associated audio and audio behaviors 2013-09-27 16:01:37 -07:00
mail Remove the last hardcoding from PhabricatorMetaMTAReceivedMail 2013-05-17 10:00:49 -07:00
phid Policy - introduce parentQuery and pass around policy configuration from parent to child 2013-09-11 12:19:34 -07:00
query Kill PhabricatorObjectDataHandle 2013-09-11 12:27:28 -07:00
remarkup Fix two issues with audio macros 2013-09-28 15:32:48 -07:00
storage Allow macros to have associated audio and audio behaviors 2013-09-27 16:01:37 -07:00