revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-23 23:32:40 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/view
History
epriestley b592630d72 Provide more structure to PHUIObjectBoxView 
Summary:
Three changes here.

  - Add `setActionList()`, and use that to set the action list.
  - Add `setPropertyList()`, and use that to set the property list.

These will let us add some apropriate CSS so we can fix the border issue, and get rid of a bunch of goofy `.x + .y` selectors.

  - Replace `addContent()` with `appendChild()`.

This is just a consistency thing; `AphrontView` already provides `appendChild()`, and `addContent()` did the same thing.

Test Plan:
  - Viewed "All Config".
  - Viewed a countdown.
  - Viewed a revision (add comment, change list, table of contents, comment, local commits, open revisions affecting these files, update history).
  - Viewed Diffusion (browse, change, history, repository, lint).
  - Viewed Drydock (resource, lease).
  - Viewed Files.
  - Viewed Herald.
  - Viewed Legalpad.
  - Viewed macro (edit, edit audio, view).
  - Viewed Maniphest.
  - Viewed Applications.
  - Viewed Paste.
  - Viewed People.
  - Viewed Phulux.
  - Viewed Pholio.
  - Viewed Phame (blog, post).
  - Viewed Phortune (account, product).
  - Viewed Ponder (questions, answers, comments).
  - Viewed Releeph.
  - Viewed Projects.
  - Viewed Slowvote.

NOTE: Images in Files aren't on a black background anymore -- I assume that's on purpose?

NOTE: Some jankiness in Phortune, I'll clean that up when I get back to it. Not related to this diff.

Reviewers: chad

Reviewed By: chad

CC: aran

Differential Revision: https://secure.phabricator.com/D7174
2013-09-30 09:36:04 -07:00
..
__tests__ Provide hasChildren() to replace isEmptyContent() 2013-08-12 07:51:01 -07:00
control When pagers aren't connected to an ObjectItemListView, put them in a little box 2013-09-13 14:43:33 -07:00
form Move PHUIFormBoxView to PHUIObjectBoxView 2013-09-25 11:23:29 -07:00
layout Add objectheaders to new View 2013-09-28 15:55:38 -07:00
page Show "Search" in menubar while logged out if users can access it 2013-09-27 10:49:59 -07:00
phui Provide more structure to PHUIObjectBoxView 2013-09-30 09:36:04 -07:00
widget Hovercard tweaks 2013-04-06 21:16:55 -07:00
AphrontDialogView.php Update Form Layouts 2013-08-26 11:53:11 -07:00
AphrontJavelinView.php Partial fix for Javelin View Example 2013-07-16 13:31:43 -07:00
AphrontNullView.php Provide hasChildren() to replace isEmptyContent() 2013-08-12 07:51:01 -07:00
AphrontTagView.php Remove all the container node stuff from AphrontTagView 2013-06-05 16:21:55 -07:00
AphrontView.php Provide hasChildren() to replace isEmptyContent() 2013-08-12 07:51:01 -07:00
viewutils.php User preference for time format 2013-09-02 12:55:11 -07:00