1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-06 12:51:01 +01:00
phorge-phorge/src/applications/conpherence/query
epriestley 3ab6a7e19f Generate "stub" events earlier, so more infrastructure works with Calendar
Summary:
Ref T9275. When you create a recurring event which recurs forever, we want to avoid writing an infinite number of rows to the database.

Currently, we write a row to the database right before you edit the event. Until then, we refer to it as `E123/999` or whatever ("instance 999 of event 123").

This creates a big mess with trying to make recurring events work with EditEngine, Subscriptions, Projects, Flags, Tokens, etc -- all of this stuff assumes that whatever you're working with has a PHID.

I poked at letting this stuff work without a PHID a little bit, but that looked like a gigantic mess.

Instead, generate an event "stub" a little sooner (when you look at the event detail page). This is basically just an ID/PHID to refer to the instance.

Then, when you edit the stub, "materialize" it into a real event.

This still has some issues, but I think it's more promising than the other approach was.

Also:

  - Removes dead user profile calendar controller.
  - Replaces comments with EditEngine comments.

Test Plan:
  - Commented on a recurring event.
  - Awarded tokens to a recurring event.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9275

Differential Revision: https://secure.phabricator.com/D16248
2016-07-13 07:41:16 -07:00
..
ConpherenceFulltextQuery.php Implement very rough message context for Conpherence search 2015-04-28 11:43:56 -07:00
ConpherenceParticipantCountQuery.php Make buildWhereClause() a method of AphrontCursorPagedPolicyAwareQuery 2015-04-20 10:06:09 -07:00
ConpherenceParticipantQuery.php Make buildWhereClause() a method of AphrontCursorPagedPolicyAwareQuery 2015-04-20 10:06:09 -07:00
ConpherenceThreadQuery.php Generate "stub" events earlier, so more infrastructure works with Calendar 2016-07-13 07:41:16 -07:00
ConpherenceThreadSearchEngine.php Convert all calls to 'IconFont' to just 'Icon' 2016-01-27 20:59:27 -08:00
ConpherenceTransactionQuery.php Fix Conpherence transaction ordering 2015-04-13 12:34:37 -07:00