mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-16 03:42:41 +01:00
6cc196a2e5
Summary: - `kill_init.php` said "Moving 1000 files" - I hope that this is not some limit in `FileFinder`. - [src/infrastructure/celerity] `git mv utils.php map.php; git mv api/utils.php api.php` - Comment `phutil_libraries` in `.arcconfig` and run `arc liberate`. NOTE: `arc diff` timed out so I'm pushing it without review. Test Plan: /D1234 Browsed around, especially in `applications/repository/worker/commitchangeparser` and `applications/` in general. Auditors: epriestley Maniphest Tasks: T1103
102 lines
3.2 KiB
PHP
102 lines
3.2 KiB
PHP
<?php
|
|
|
|
/*
|
|
* Copyright 2012 Facebook, Inc.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
final class DifferentialCommentSaveController extends DifferentialController {
|
|
|
|
public function processRequest() {
|
|
$request = $this->getRequest();
|
|
if (!$request->isFormPost()) {
|
|
return new Aphront400Response();
|
|
}
|
|
|
|
$revision_id = $request->getInt('revision_id');
|
|
$revision = id(new DifferentialRevision())->load($revision_id);
|
|
if (!$revision) {
|
|
return new Aphront400Response();
|
|
}
|
|
|
|
$comment = $request->getStr('comment');
|
|
$action = $request->getStr('action');
|
|
$reviewers = $request->getArr('reviewers');
|
|
$ccs = $request->getArr('ccs');
|
|
|
|
$editor = new DifferentialCommentEditor(
|
|
$revision,
|
|
$request->getUser()->getPHID(),
|
|
$action);
|
|
|
|
$content_source = PhabricatorContentSource::newForSource(
|
|
PhabricatorContentSource::SOURCE_WEB,
|
|
array(
|
|
'ip' => $request->getRemoteAddr(),
|
|
));
|
|
|
|
try {
|
|
$editor
|
|
->setMessage($comment)
|
|
->setContentSource($content_source)
|
|
->setAttachInlineComments(true)
|
|
->setAddedReviewers($reviewers)
|
|
->setAddedCCs($ccs)
|
|
->save();
|
|
} catch (DifferentialActionHasNoEffectException $no_effect) {
|
|
$has_inlines = id(new DifferentialInlineComment())->loadAllWhere(
|
|
'authorPHID = %s AND revisionID = %d AND commentID IS NULL',
|
|
$request->getUser()->getPHID(),
|
|
$revision->getID());
|
|
|
|
$dialog = new AphrontDialogView();
|
|
$dialog->setUser($request->getUser());
|
|
$dialog->addCancelButton('/D'.$revision_id);
|
|
|
|
$dialog->addHiddenInput('revision_id', $revision_id);
|
|
$dialog->addHiddenInput('action', 'none');
|
|
$dialog->addHiddenInput('reviewers', $reviewers);
|
|
$dialog->addHiddenInput('ccs', $ccs);
|
|
$dialog->addHiddenInput('comment', $comment);
|
|
|
|
$dialog->setTitle('Action Has No Effect');
|
|
$dialog->appendChild(
|
|
'<p>'.phutil_escape_html($no_effect->getMessage()).'</p>');
|
|
|
|
if (strlen($comment) || $has_inlines) {
|
|
$dialog->addSubmitButton('Post as Comment');
|
|
$dialog->appendChild('<br />');
|
|
$dialog->appendChild(
|
|
'<p>Do you want to post your feedback anyway, as a normal '.
|
|
'comment?</p>');
|
|
}
|
|
|
|
return id(new AphrontDialogResponse())->setDialog($dialog);
|
|
}
|
|
|
|
// TODO: Diff change detection?
|
|
|
|
$draft = id(new PhabricatorDraft())->loadOneWhere(
|
|
'authorPHID = %s AND draftKey = %s',
|
|
$request->getUser()->getPHID(),
|
|
'differential-comment-'.$revision->getID());
|
|
if ($draft) {
|
|
$draft->delete();
|
|
}
|
|
|
|
return id(new AphrontRedirectResponse())
|
|
->setURI('/D'.$revision->getID());
|
|
}
|
|
|
|
}
|