1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-09-22 18:28:47 +02:00
phorge-phorge/src/applications/differential
epriestley 193a9611e4 Partially generalize Remarkup previews and add support to Differential
Summary:
Ref T3671. A lot of applications have pretty ad-hoc preview code. Clean it up a bit and add Summary preview to Differential.

After ApplicationTransactions we might want to try to serialize the whole form and show a preview of all the transactions, but this seems not very useful in most cases (I'd guess that Remarkup previews are 99% of the value) and tricky to get right (e.g., adding images which don't exist yet to Pholio mocks).

I think I can add this in a few other places, too.

Test Plan:
Edited Maniphest Tasks and Differential Revisions, mashed some buttons. Verified previews rendered correctly. Grepped for removed CSS classes (no hits).

{F52907}

Reviewers: btrahan, Firehed

Reviewed By: btrahan

CC: aran, chad

Maniphest Tasks: T3671

Differential Revision: https://secure.phabricator.com/D6673
2013-08-05 10:46:39 -07:00
..
__tests__ Require a viewer for Remarkup rendering 2013-03-04 12:33:05 -08:00
application Partially generalize Remarkup previews and add support to Differential 2013-08-05 10:46:39 -07:00
conduit Use DifferentialRevisionQuery in conduit when reviewers are needed 2013-07-15 03:29:13 -07:00
config Flip strings for 'metamta.differential.unified-comment-context' config 2013-04-26 06:19:07 -07:00
constants Store revision reviewer state as edges 2013-07-10 13:50:21 -07:00
controller Partially generalize Remarkup previews and add support to Differential 2013-08-05 10:46:39 -07:00
doorkeeper Publish create object stories into Asana sort of, but not really 2013-08-01 12:19:18 -07:00
editor Fix typo in D6372 2013-07-10 16:26:38 -07:00
events Make PhabricatorActionListView logged-out user savvy 2013-07-12 11:39:47 -07:00
exception Delete license headers from files 2012-11-05 11:16:51 -08:00
field Partially generalize Remarkup previews and add support to Differential 2013-08-05 10:46:39 -07:00
lipsum xDiffs and Revisions Generating 2013-05-06 14:11:37 -07:00
mail Move PhabricatorUser to new phid stuff 2013-07-26 14:05:19 -07:00
parser Fix typo in comment 2013-06-28 09:40:00 -07:00
phid Fix "setName()" on Differental revision handles 2013-07-22 14:42:31 -07:00
query Remove unnecessary empty checks from willFilterPage() 2013-07-24 15:30:26 -07:00
remarkup Require a viewer for Remarkup rendering 2013-03-04 12:33:05 -08:00
render Fix function/method declaration lint in Phabricator. Automatic patches. 2013-02-19 13:47:03 -08:00
search Move PhabricatorUser to new phid stuff 2013-07-26 14:05:19 -07:00
storage Move DifferentialRevision to application PHIDs 2013-07-22 12:17:29 -07:00
view Fix missing label in Request Review 2013-07-17 11:37:54 -07:00
DifferentialTasksAttacher.php Delete license headers from files 2012-11-05 11:16:51 -08:00