mirror of
https://we.phorge.it/source/phorge.git
synced 2025-01-21 04:01:30 +01:00
114ed6c7fe
Summary:
This accomplishes three major goals:
# Fixes phutil_render_tag -> phutil_tag callsites in DarkConsole.
# Moves the Ajax request log to a new panel on the left. This panel (and the tabs panel) get scrollbars when they get large, instead of making the page constantly scroll down.
# Loads the panel content over ajax, instead of dumping it into the page body / ajax response body. I've been planning to do this for about 3 years, which is why the plugins are architected the way they are. This should make debugging easier by making response bodies not be 50%+ darkconsole stuff.
Additionally, load the plugins dynamically (the old method predates library maps and PhutilSymbolLoader).
Test Plan:
{F30675}
- Switched between requests and tabs, reloaded page, saw same tab.
- Used "analyze queries", "profile page", triggered errors.
- Verified page does not load anything by default if dark console is closed with Charles.
- Generally banged on it a bit.
Reviewers: vrana, btrahan, chad
Reviewed By: vrana
CC: aran
Maniphest Tasks: T2432
Differential Revision: https://secure.phabricator.com/D4692
106 lines
2.6 KiB
PHP
106 lines
2.6 KiB
PHP
<?php
|
|
|
|
/**
|
|
* @group console
|
|
*/
|
|
final class DarkConsoleXHProfPlugin extends DarkConsolePlugin {
|
|
|
|
protected $xhprofID;
|
|
|
|
public function getName() {
|
|
return 'XHProf';
|
|
}
|
|
|
|
public function getColor() {
|
|
$data = $this->getData();
|
|
if ($data['xhprofID']) {
|
|
return '#ff00ff';
|
|
}
|
|
return null;
|
|
}
|
|
|
|
public function getDescription() {
|
|
return 'Provides detailed PHP profiling information through XHProf.';
|
|
}
|
|
|
|
public function generateData() {
|
|
return array(
|
|
'xhprofID' => $this->xhprofID,
|
|
'profileURI' => (string)$this
|
|
->getRequestURI()
|
|
->alter('__profile__', 'page'),
|
|
);
|
|
}
|
|
|
|
public function getXHProfRunID() {
|
|
return $this->xhprofID;
|
|
}
|
|
|
|
public function renderPanel() {
|
|
$data = $this->getData();
|
|
|
|
$run = $data['xhprofID'];
|
|
$profile_uri = $data['profileURI'];
|
|
|
|
if (!DarkConsoleXHProfPluginAPI::isProfilerAvailable()) {
|
|
$href = PhabricatorEnv::getDoclink('article/Installation_Guide.html');
|
|
$install_guide = phutil_tag(
|
|
'a',
|
|
array(
|
|
'href' => $href,
|
|
'class' => 'bright-link',
|
|
),
|
|
'Installation Guide');
|
|
return
|
|
'<div class="dark-console-no-content">'.
|
|
'The "xhprof" PHP extension is not available. Install xhprof '.
|
|
'to enable the XHProf console plugin. You can find instructions in '.
|
|
'the '.$install_guide.'.'.
|
|
'</div>';
|
|
}
|
|
|
|
$result = array();
|
|
|
|
$header =
|
|
'<div class="dark-console-panel-header">'.
|
|
phutil_tag(
|
|
'a',
|
|
array(
|
|
'href' => $profile_uri,
|
|
'class' => $run
|
|
? 'disabled button'
|
|
: 'green button',
|
|
),
|
|
'Profile Page').
|
|
'<h1>XHProf Profiler</h1>'.
|
|
'</div>';
|
|
$result[] = $header;
|
|
|
|
if ($run) {
|
|
$result[] =
|
|
'<a href="/xhprof/profile/'.$run.'/" '.
|
|
'class="bright-link" '.
|
|
'style="float: right; margin: 1em 2em 0 0;'.
|
|
'font-weight: bold;" '.
|
|
'target="_blank">Profile Permalink</a>'.
|
|
'<iframe src="/xhprof/profile/'.$run.'/?frame=true"></iframe>';
|
|
} else {
|
|
$result[] =
|
|
'<div class="dark-console-no-content">'.
|
|
'Profiling was not enabled for this page. Use the button above '.
|
|
'to enable it.'.
|
|
'</div>';
|
|
}
|
|
|
|
return implode("\n", $result);
|
|
}
|
|
|
|
|
|
public function willShutdown() {
|
|
if (DarkConsoleXHProfPluginAPI::isProfilerRequested() &&
|
|
(DarkConsoleXHProfPluginAPI::isProfilerRequested() !== 'all')) {
|
|
$this->xhprofID = DarkConsoleXHProfPluginAPI::stopProfiler();
|
|
}
|
|
}
|
|
|
|
}
|